[PATCH] clk: Return value calculated by ERR_PTR

[Andrew Goodbody]

ping?

On 03/07/2025 15:40, Andrew Goodbody wrote:
> In clk_set_default_get_by_id ret is passed to ERR_PTR but nothing is
> done with the value that this calculates which is obviously not the
> intention of the code. This is confirmed by the code around where this
> function is called.
> Instead return the value from ERR_PTR.
> 
> This issue found by Smatch.
> 
> Signed-off-by: Andrew Goodbody <andrew.goodbody at linaro.org>
> ---
>   drivers/clk/clk-uclass.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c
> index 2167cd5ad0f..cf48de766fe 100644
> --- a/drivers/clk/clk-uclass.c
> +++ b/drivers/clk/clk-uclass.c
> @@ -194,7 +194,7 @@ static struct clk *clk_set_default_get_by_id(struct clk *clk)
>   		if (ret) {
>   			debug("%s(): could not get parent clock pointer, id %lu\n",
>   			      __func__, clk->id);
> -			ERR_PTR(ret);
> +			return ERR_PTR(ret);
>   		}
>   	}
>   
> 
> ---
> base-commit: 7027b445cc0bfb86204ecb1f1fe596f5895048d9
> change-id: 20250703-clk_uclass_fix-eaf648b2ebb5
> 
> Best regards,