[PATCH 1/1] pylibfdt: correct license information

[Heinrich Schuchardt]

On 10.06.25 12:53, Quentin Schulz wrote:
> Hi Heinrich,
> 
> On 6/7/25 1:32 PM, Heinrich Schuchardt wrote:
>> Setuptools 78.1.1 shows warnings:
>>
>> * Pattern 'GPL' did not match any files.
>> * Pattern 'BSD-2-Clause' did not match any files.
>> * SetuptoolsDeprecationWarning: License classifiers are deprecated.
>>
>> Cf. https://packaging.python.org/en/latest/guides/writing-pyproject- 
>> toml/#license
>>
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
>> ---
>>   scripts/dtc/pylibfdt/setup.py | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/scripts/dtc/pylibfdt/setup.py b/scripts/dtc/pylibfdt/ 
>> setup.py
>> index c6fe5a6a446..487e669f524 100755
>> --- a/scripts/dtc/pylibfdt/setup.py
>> +++ b/scripts/dtc/pylibfdt/setup.py
>> @@ -158,12 +158,10 @@ setup(
>>       long_description_content_type="text/plain",
>>       url="https://git.kernel.org/pub/scm/utils/dtc/dtc.git",
>>       license="BSD",
>> -    license_files=["GPL", "BSD-2-Clause"],
>> +    license_files=["Licenses/gpl-2.0.txt", "Licenses/bsd-2-clause.txt"],
>>       classifiers=[
>>           "Programming Language :: Python :: 3",
>> -        "License :: OSI Approved :: BSD License",
>> -        "License :: OSI Approved :: GNU General Public License v2 or 
>> later (GPLv2+)",
> 
> This is an issue though, as it's supposed to be replaced by the license 
> argument to the setuptools.setup() function and we aren't matching there 
> (though tbf, we weren't already matching :) ).

Upstream setup tools has been changed to ignore these lines.

> 
> Also, I'm not entirely sure BSD is unambiguous?

There are BSD Zero Clause License, BSD 1-Clause License, BSD-2-Clause, 
and BSD-3-Clause, and further variants. See

https://spdx.org/licenses/

The linked files in license_files are unambiguous.

> 
> I would suggest:
> 
> license="GPL-2.0-or-later OR BSD-2-Clause"
> 
> to match the SPDX-License-Identifier at the top if the setup.py file :)

51ec8db23280 ("pylibfdt: correct license information") is already 
merged. Please, send a new patch id you want to change the license field.

Best regards

Heinrich