[PATCH] Improve user feedback in case of FPGA bitstream load failure

Michal Simek michal.simek at amd.com
Wed Jun 18 09:15:54 CEST 2025



On 6/17/25 11:23, vtpieter at gmail.com wrote:
> From: Pieter Van Trappen <pieter.van.trappen at cern.ch>
> 
> In fpga.c, change debug() calls to puts() for important user
> feedback. In zynqpl.c, change 'up to' to 'above' which corrects this
> confusing or wrong statement.
> 
> Signed-off-by: Pieter Van Trappen <pieter.van.trappen at cern.ch>
> ---
>   cmd/fpga.c            | 20 ++++++++++----------
>   drivers/fpga/zynqpl.c |  2 +-
>   2 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/cmd/fpga.c b/cmd/fpga.c
> index 9dc7b63db5d..2c2a63524de 100644
> --- a/cmd/fpga.c
> +++ b/cmd/fpga.c
> @@ -43,7 +43,7 @@ static int do_fpga_check_params(long *dev, long *fpga_data, size_t *data_size,
>   	debug("%s %d, %d\n", __func__, argc, cmdtp->maxargs);
>   
>   	if (argc != cmdtp->maxargs) {
> -		debug("fpga: incorrect parameters passed\n");
> +		puts("fpga: incorrect parameters passed\n");

I think all of these should be moved to log_err that you should be able to 
control verbosity.

Tom: I think this is where you want to go right?

Thanks,
Michal


More information about the U-Boot mailing list