[PATCH] Improve user feedback in case of FPGA bitstream load failure

[Tom Rini]

On Wed, Jun 18, 2025 at 09:15:54AM +0200, Michal Simek wrote:
> 
> 
> On 6/17/25 11:23, vtpieter at gmail.com wrote:
> > From: Pieter Van Trappen <pieter.van.trappen at cern.ch>
> > 
> > In fpga.c, change debug() calls to puts() for important user
> > feedback. In zynqpl.c, change 'up to' to 'above' which corrects this
> > confusing or wrong statement.
> > 
> > Signed-off-by: Pieter Van Trappen <pieter.van.trappen at cern.ch>
> > ---
> >   cmd/fpga.c            | 20 ++++++++++----------
> >   drivers/fpga/zynqpl.c |  2 +-
> >   2 files changed, 11 insertions(+), 11 deletions(-)
> > 
> > diff --git a/cmd/fpga.c b/cmd/fpga.c
> > index 9dc7b63db5d..2c2a63524de 100644
> > --- a/cmd/fpga.c
> > +++ b/cmd/fpga.c
> > @@ -43,7 +43,7 @@ static int do_fpga_check_params(long *dev, long *fpga_data, size_t *data_size,
> >   	debug("%s %d, %d\n", __func__, argc, cmdtp->maxargs);
> >   	if (argc != cmdtp->maxargs) {
> > -		debug("fpga: incorrect parameters passed\n");
> > +		puts("fpga: incorrect parameters passed\n");
> 
> I think all of these should be moved to log_err that you should be able to
> control verbosity.
> 
> Tom: I think this is where you want to go right?

Sounds right, thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250618/ac41ec58/attachment.sig>