Re: 回复: [PATCH v6 10/20] scmi_protocols: update struct scmi_base_discover_list_protocols_out

[Marek Vasut]

On 3/3/25 11:43 AM, Alice Guo (OSS) wrote:

Hi,

>>> diff --git a/include/scmi_protocols.h b/include/scmi_protocols.h index
>>> 2684f4177d..7ce73ddfae 100644
>>> --- a/include/scmi_protocols.h
>>> +++ b/include/scmi_protocols.h
>>> @@ -141,11 +141,14 @@ struct scmi_base_discover_impl_version_out {
>>>     * @status:		SCMI command status
>>>     * @num_protocols:	Number of SCMI protocols in @protocol
>>>     * @protocols:		Array of packed SCMI protocol ID's
>>> + *
>>> + * The number of elements of @protocols is specified by callee-side.
>>> + Currently,
>>> + * set it to 4 is enough for i.MX95.
>>>     */
>>>    struct scmi_base_discover_list_protocols_out {
>>>    	s32 status;
>>>    	u32 num_protocols;
>>> -	u32 protocols[3];
>>> +	u32 protocols[4];
>>
>> Can this be made dynamic ? I think I already asked about this last time, but v4
>> feedback was not addressed, can you please double-check that v4 feedback ? I
>> will review next version once it is addressed .
> 
> Sorry for not replying to your comments for v4. I have just replied in v4 and want to discuss this change with you.
No worries, thanks.