[PATCH 01/11] net: miiphybb: Split off struct bb_miiphy_bus_ops
Marek Vasut
marek.vasut at mailbox.org
Tue Mar 4 00:16:23 CET 2025
On 3/3/25 8:29 PM, Paul Barker wrote:
> On 02/03/2025 01:24, Marek Vasut wrote:
>> Move miiphybb operations into separate struct bb_miiphy_bus_ops
>> structure, add pointer to struct bb_miiphy_bus_ops into the base
>> struct bb_miiphy_bus and access the ops through this pointer in
>> miiphybb generic code. The variable reshuffling in miiphybb.c
>> cannot be easily avoided.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
>
> Hi Marek,
>
> I'm a bit lost trying to review this series. Could you include a cover
> letter summarising the change to the bitbangmii API? We also need to
> update `doc/README.bitbangMII`.
In short, this splits ops from the bbmiiphy structure, which is entirely
removed in the course of this series, and so are all the bbmiiphy
alloc/free functions again. That in turn fixes the missed mdio_free()
update, which no longer has to be fixed, as the drivers go back to
mdio_alloc() to allocate the MDIO bus.
> This also means I need to rebase my Ethernet patches again.... I have a
> few bugfixes for R-Car & RZ/G2H, plus some refactoring and the addition
> of support for RZ/G2L which all conflict with the churn in ravb.c.
Sorry about that.
--
Best regards,
Marek Vasut
More information about the U-Boot
mailing list