回复: 回复: [PATCH v6 02/20] firmware: scmi: smt: Interrupt communication enable

[Alice Guo (OSS)]

> -----邮件原件-----
> 发件人: Marek Vasut <marex at denx.de>
> 发送时间: 2025年3月4日 5:05
> 收件人: Alice Guo (OSS) <alice.guo at oss.nxp.com>; Tom Rini
> <trini at konsulko.com>; Stefano Babic <sbabic at denx.de>; Fabio Estevam
> <festevam at gmail.com>; dl-uboot-imx <uboot-imx at nxp.com>; Lukasz
> Majewski <lukma at denx.de>; Sean Anderson <seanga2 at gmail.com>; Simon
> Glass <sjg at chromium.org>; Alper Nebi Yasak <alpernebiyasak at gmail.com>;
> Alice Guo <alice.guo at nxp.com>
> 抄送: u-boot at lists.denx.de; Viorel Suman <viorel.suman at nxp.com>; Ye Li
> <ye.li at nxp.com>
> 主题: Re: 回复: [PATCH v6 02/20] firmware: scmi: smt: Interrupt
> communication enable
> 
> On 3/3/25 3:51 AM, Alice Guo (OSS) wrote:
> 
> Hi,
> 
> >>> @@ -48,6 +58,9 @@ int scmi_dt_get_smt_buffer(struct udevice *dev,
> >>> struct
> >> scmi_smt *smt)
> >>>    	if (!smt->buf)
> >>>    		return -ENOMEM;
> >>>
> >>> +	if (IS_ENABLED(CONFIG_SCMI_TRANSPORT_SMT_INTR))
> >>> +		scmi_smt_enable_intr(smt, true);
> >> Would it be possible to check DT /firmware/scmi node for compatible
> >> == "arm,scmi" and presence of "mboxes" property , and based on that ,
> >> determine that this is mailbox based SCMI ?
> >
> > Hi Marek,
> >
> > Do you mean that replace
> IS_ENABLED(CONFIG_SCMI_TRANSPORT_SMT_INTR) by checking "arm,scmi"
> and "mboxes" in device tree?
> If that is possible, yes.

I do not think that Bit[0] of channel flags should be set to 1 only when the SCMI node has the compatible "arm,scmi" and the property "mboxes". Whether to set it depends on the implementation of the SCMI callee-side.