[PATCH v2] led: fix next coverity scan error
Tom Rini
trini at konsulko.com
Wed Mar 5 05:34:55 CET 2025
On Wed, 26 Feb 2025 10:18:58 +0100, Heiko Schocher wrote:
> Tom reported the following covervity scan error:
>
> *** CID 542488: Control flow issues (NO_EFFECT)
> /drivers/led/led-uclass.c: 277 in led_get_function_name()
> 271 return uc_plat->label;
> 272
> 273 /* Now try to detect function label name */
> 274 func = dev_read_string(dev, "function");
> 275 cp = dev_read_u32(dev, "color", &color);
> 276 // prevent coverity scan error CID 541279: (TAINTED_SCALAR)
> >>> CID 542488: Control flow issues (NO_EFFECT)
> >>> This less-than-zero comparison of an unsigned value is never true.
> "color < 0U".
> 277 if (color < LED_COLOR_ID_WHITE || color >= LED_COLOR_ID_MAX)
> 278 cp = -EINVAL;
> 279
>
> [...]
Applied to u-boot/master, thanks!
--
Tom
More information about the U-Boot
mailing list