[EXTERNAL] Re: [PATCH 08/10] configs: ti_armv7_common: add cfgs for SPI falcon boot

[Anshul Dalal]

On Fri Mar 7, 2025 at 9:27 PM IST, Tom Rini wrote:
> On Fri, Mar 07, 2025 at 01:25:36PM +0530, Anshul Dalal wrote:
>
> > When booting from SPI, only the tispl.bin and tiboot3.bin is loaded from
> > the SPI. tiboot3.bin is located by the ROM and tispl.bin's offset is
> > specified by CONFIG_SYS_SPI_U_BOOT_OFFS.
> > 
> > The kernel and args however are loaded from the eMMC or SD and not SPI,
> > therefore we don't actually make use of these config values at runtime,
> > they are added to avoid compile time 'undefined identifier' errors when
> > building with SPL_OS_BOOT enabled.
> > 
> > Signed-off-by: Anshul Dalal <anshuld at ti.com>
> > ---
> >  include/configs/ti_armv7_common.h | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h
> > index 3def7b1027e..f101d10992a 100644
> > --- a/include/configs/ti_armv7_common.h
> > +++ b/include/configs/ti_armv7_common.h
> > @@ -119,6 +119,12 @@
> >  /* FAT */
> >  
> >  /* RAW SD card / eMMC */
> > +
> > +/* SPI */
> > +#define CFG_SYS_SPI_KERNEL_OFFS	0
> > +#define CFG_SYS_SPI_ARGS_OFFS	0
> > +#define CFG_SYS_SPI_ARGS_SIZE	0
> > +
> >  #endif
>
> We need to refactor the code and migrate these to Kconfig as well.

Yeah, we're already using Kconfig for raw eMMC as well doing the same
for SPI make sense.

Anshul