[PATCH 02/10] cmd: Kconfig: enable CMD_BOOTI for ARCH_K3

[Tom Rini]

On Mon, Mar 10, 2025 at 10:48:47AM +0530, Anshul Dalal wrote:
> On Fri Mar 7, 2025 at 9:50 PM IST, Tom Rini wrote:
> > On Fri, Mar 07, 2025 at 09:43:19PM +0530, Anshul Dalal wrote:
> > > On Fri Mar 7, 2025 at 9:20 PM IST, Tom Rini wrote:
> > > > On Fri, Mar 07, 2025 at 01:25:30PM +0530, Anshul Dalal wrote:
> > > >
> > > > > This allows us to load the kernel image to memory on 32-bit R5 SPL.
> > > > > 
> > > > > Signed-off-by: Anshul Dalal <anshuld at ti.com>
> > > > > ---
> > > > >  cmd/Kconfig | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/cmd/Kconfig b/cmd/Kconfig
> > > > > index a04fcaa0e08..66145a001b8 100644
> > > > > --- a/cmd/Kconfig
> > > > > +++ b/cmd/Kconfig
> > > > > @@ -357,7 +357,7 @@ config CMD_BOOTZ
> > > > >  
> > > > >  config CMD_BOOTI
> > > > >  	bool "booti"
> > > > > -	depends on ARM64 || RISCV || SANDBOX
> > > > > +	depends on ARM64 || RISCV || SANDBOX || ARCH_K3
> > > >
> > > > How are you using "booti" on the R5 part of K3? This shouldn't be
> > > > useful...
> > > 
> > > This is necessary to allow us to call booti_setup [the code path
> > > responsible for parsing uncompressed kernel image] from
> > > spl_parse_image_header at common/spl/spl.c:338 when loading the Image.
> >
> > OK, so please update arch/arm/lib/Makefile with something like:
> > ifdef CONFIG_ARCH_K3
> > obj-$(CONFIG_SPL_OS_BOOT) += booti.o
> > endif
> 
> We would still have to have CMD_BOOTI enabled even with this change
> because of the check at common/spl/spl.c:338. I suggest we proceed with
> my original set of changes instead.

No, things need to be reworked more then as it doesn't make logical
sense to enable a command in SPL (where there are no commands). It's odd
enough that we need to enable support for image formats that don't exist
on 32bit arm, on 32bit arm. What's there in common/spl/spl.c:338 (and
the next check) is a short-hand.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250310/95db8e5f/attachment.sig>