[PATCH 12/12] test_fs: Add exfat tests

[Marek Vasut]

On 3/10/25 10:37 PM, Tom Rini wrote:
> On Mon, Mar 10, 2025 at 09:37:36PM +0100, Marek Vasut wrote:
>> On 3/10/25 4:30 PM, Tom Rini wrote:
>>> On Sat, Mar 08, 2025 at 09:12:16PM +0100, Marek Vasut wrote:
>>>> Add tests for the exfat filesystem. These tests are largely an
>>>> extension of the FS_GENERIC tests with the following notable
>>>> exceptions.
>>>>
>>>> The filesystem image for exfat tests is generated using combination
>>>> of exfatutils mkfs.exfat and python fattools. The fattols are capable
>>>
>>> Did you mean "exfatprogs" and not "exfatutils" ? But we need to update
>>> tools/docker/Dockerfile to list the tool there.
>>
>> It seems the CI container already has the tools in it ?
> 
> Implicitly and not explicitly then.
> 
>> Where do I update the docker container, is that tools/docker/Dockerfile ?
> 
> Yes, thanks.

Added in V2, thanks.

>>>> of generating exfat filesystem images too, but this is not used, the
>>>
>>> Presumably because "fattools mkfat" seems to have further external
>>> dependencies and so would be more of a pain to use.
>>
>> I don't think it does, but I think we should stick to tools which will be in
>> production systems as much as possible, and that is mkfs.exfat from
>> exfatprogs . The fattools is only used here because mkfs.exfat cannot create
>> an image from list of files.
> 
> Well, I tried "fattools mkfs.exfat" and it wanted tkinter to be
> installed, so that's why I'd not bother with it.
Uh OK.