[PATCH v2 1/1] cmd: simplify eficonfig_init()

[Ilias Apalodimas]

On Mon, 10 Mar 2025 at 08:13, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
> As the system table already has pointers to the Simple Text Input and
> Output Protocols we can directly use these instead of calling
> OpenProtocol.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> ---
> v2:
>         remove unused variable handler
> ---
>  cmd/eficonfig.c | 19 ++-----------------
>  1 file changed, 2 insertions(+), 17 deletions(-)
>
> diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c
> index e08b6ba4a5d..629bf1b82c7 100644
> --- a/cmd/eficonfig.c
> +++ b/cmd/eficonfig.c
> @@ -2283,26 +2283,11 @@ static efi_status_t eficonfig_init(void)
>  {
>         efi_status_t ret = EFI_SUCCESS;
>         static bool init;
> -       struct efi_handler *handler;
>         unsigned long columns, rows;
>
>         if (!init) {
> -               ret = efi_search_protocol(efi_root, &efi_guid_text_input_protocol, &handler);
> -               if (ret != EFI_SUCCESS)
> -                       return ret;
> -
> -               ret = efi_protocol_open(handler, (void **)&cin, efi_root, NULL,
> -                                       EFI_OPEN_PROTOCOL_GET_PROTOCOL);
> -               if (ret != EFI_SUCCESS)
> -                       return ret;
> -               ret = efi_search_protocol(efi_root, &efi_guid_text_output_protocol, &handler);
> -               if (ret != EFI_SUCCESS)
> -                       return ret;
> -
> -               ret = efi_protocol_open(handler, (void **)&cout, efi_root, NULL,
> -                                       EFI_OPEN_PROTOCOL_GET_PROTOCOL);
> -               if (ret != EFI_SUCCESS)
> -                       return ret;
> +               cout = systab.con_out;
> +               cin = systab.con_in;
>
>                 cout->query_mode(cout, cout->mode->mode, &columns, &rows);
>                 avail_row = rows - (EFICONFIG_MENU_HEADER_ROW_NUM +
> --
> 2.48.1
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>