[PATCH 1/2] imx8qxp: Do not use CONFIG_XPL_BUILD in device tree

[Hendrik Donner]

Hello,

On 17.03.25 12:10, Quentin Schulz wrote:
> Hi Fabio,
> 
> On 3/15/25 12:58 PM, Fabio Estevam wrote:
>> Hi Hendrik,
>>
>> On Fri, Mar 14, 2025 at 5:09 PM Hendrik Donner <hd at os-cillation.de> 
>> wrote:
>>>
>>> In c9713c155127 the device tree was moved
>>> from CONFIG_SPL to CONFIG_SPL_BUILD and later to CONFIG_XPL_BUILD, but
>>> the CONFIG_xPL_BUILD defines are never set for device trees, breaking
>>> the build. Move the guards back to CONFIG_SPL.
>>
>> Please provide details about the "breaking the build". Which target
> 
> The nodes will simply never be added, because CONFIG_XPL_BUILD (or 
> CONFIG_SPL_BUILD) simply aren't passed to dtc.
> 
> So essentially, this is equivalent to dead/noop code.
> 
>> fails to build currently?
>>
>> After applying this series, the previous build failures return:
>>
> 
> Yes, it was never fixed, just silenced by never building it.
> 
> See https://lore.kernel.org/u-boot/2849ff05-ef67-4471- 
> aece-422daa57040f at cherry.de/
> 

additional information: the documentation is already telling the user to
acquire the missing binary blobs:

https://docs.u-boot.org/en/latest/board/nxp/imx8qxp_mek.html#get-scfw-tcm-bin-and-ahab-container-img

So the error from make should not happen with the correct blobs being
present.

But most aspect were already discussed in the mail thread this patch
series was in response to.

Regards,
Hendrik

> Cheers,
> Quentin