[PATCH v1 6/6] configs: add qcom_ipq5424_mmc_defconfig

[Caleb Connolly]

On 3/12/25 08:51, Varadarajan Narayanan wrote:
> On Tue, Mar 11, 2025 at 03:27:25PM +0000, Caleb Connolly wrote:
>> Hi Varadarajan,
>>
>> Thanks for the series, and apologies for the slow reply, i've been out sick
>> and still finding my feet again.
> 
> Oops. Sorry to have troubled you.

no worries :D
> 
>> On 3/4/25 11:01, Varadarajan Narayanan wrote:
>>> Introduce a defconfig for the Qualcomm IPQ5424 SoC based RDPs.
>>> Presently supports eMMC.
>>>
>>> Per the flash memory layout, U-Boot size cannot exceed 756KB. With this
>>> defconfig, u-boot.mbn size is ~480KB.
>>
>> What are the differences between this and the other new IPQ platform? Can
>> they share a defconfig?
> 
> They are very similar. At this point, CONFIG_DEFAULT_DEVICE_TREE,
> CONFIG_CLK_QCOM_xxx, CONFIG_PINCTRL_QCOM_xxx, CONFIG_DEBUG_UART_xxx and memory
> map are different.
> 
>> Alternatively, could most of the things here be de-duplicated so there is a
>> "base" config which they both #include (similarly to qcm6490_defconfig) this
>> way we can nicely keep track of what parts of board specific.
>>
>> If you'd prefer to keep it this way that's fine too.
> 
> Would having an ipq_defconfig and including that in ipq9574 and ipq5424
> defconfigs be a good approach?

No, I don't think so since every defconfig needs to build, and that one 
would be missing options.

You could have one board inherit from another?

Perhaps it makes sense to just keep things as-is.

Kind regards,
> 
>> Should I be expecting more platforms like this?
> 
> Yes.
> 
> Thanks
> Varada
> 
> 
> [ . . . ]

-- 
Caleb (they/them)