[PATCH v2 0/5] rng: msm: fixes for MSM8916

Caleb Connolly caleb.connolly at linaro.org
Mon Mar 17 14:48:23 CET 2025


On Wed, 12 Feb 2025 07:01:20 +0000, Sam Day wrote:
> The msm-rng driver is currently broken on MSM8916.
> 
> The first issue is that the core clock isn't defined and thus not being
> enabled before registers in the PRNG block are accessed.
> 
> The second issue is that the enable method is only initializing the PRNG
> registers if the block is *already* initialized. This would have likely
> caused issues elsewhere once the driver was in more active use, but the
> problems on MSM8916 are immediate: trying to modify the state of LFSR_CFG
> causes SErrors, presumably because this register is protected by TZ.
> 
> [...]

Applied, thanks!

[1/5] clk/qcom: apq8016: use BIT macro for clk en_vals
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/61781206cf19
[2/5] clk/qcom: apq8016: add PRNG_AHB_CLK
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/d146a8771f87
[3/5] rng: msm: don't enable PRNG if it's already enabled
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/6e933cd69ad9
[4/5] clk/qcom: apq8016: improve clk_enable logging
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/dc8754e8e408
[5/5] rng: msm: keep core clock disabled when PRNG not in use
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/2babb61428dc

Best regards,
-- 
Caleb Connolly <caleb.connolly at linaro.org>



More information about the U-Boot mailing list