[PATCH 1/3] i2c: geni: fix error message wording in clk_disable
Neil Armstrong
neil.armstrong at linaro.org
Mon Mar 17 15:04:05 CET 2025
On 14/03/2025 17:09, Caleb Connolly wrote:
> Correct the error messages so they accurately describe that we failed to
> disable the clocks, not to enable them.
>
> Signed-off-by: Caleb Connolly <caleb.connolly at linaro.org>
> ---
> drivers/i2c/geni_i2c.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/geni_i2c.c b/drivers/i2c/geni_i2c.c
> index eabf5c76c21c2bc12c80dbb9fb498a0080928248..4eb41ba852f7790ca646c8ba38f29fdb727fa804 100644
> --- a/drivers/i2c/geni_i2c.c
> +++ b/drivers/i2c/geni_i2c.c
> @@ -330,17 +330,15 @@ static int geni_i2c_disable_clocks(struct udevice *dev, struct geni_i2c_priv *ge
>
> if (geni->is_master_hub) {
> ret = clk_disable(&geni->core);
> if (ret) {
> - dev_err(dev, "clk_enable core failed %d\n", ret);
> - return ret;
> + dev_err(dev, "clk_disable core failed %d\n", ret);
> }
> }
>
> ret = clk_disable(&geni->se);
> if (ret) {
> - dev_err(dev, "clk_enable se failed %d\n", ret);
> - return ret;
> + dev_err(dev, "clk_disable se failed %d\n", ret);
> }
>
> return 0;
> }
>
Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>
More information about the U-Boot
mailing list