[resend v2 06/13] drivers: i3c: Add i3c sandbox simple test.

Maniyam, Dinesh dinesh.maniyam at altera.com
Tue Mar 18 04:04:55 CET 2025



> -----Original Message-----
> From: Tom Rini <trini at konsulko.com>
> Sent: Saturday, 15 March 2025 12:53 am
> To: Maniyam, Dinesh <dinesh.maniyam at altera.com>
> Cc: u-boot at lists.denx.de; Marek <marex at denx.de>; Simon
> <simon.k.r.goldschmidt at gmail.com>; Simon Glass <sjg at chromium.org>; Dario
> Binacchi <dario.binacchi at amarulasolutions.com>; Ilias Apalodimas
> <ilias.apalodimas at linaro.org>; Heinrich Schuchardt <xypron.glpk at gmx.de>;
> Jerome Forissier <jerome.forissier at linaro.org>; Mattijs Korpershoek
> <mkorpershoek at baylibre.com>; Ibai Erkiaga <ibai.erkiaga-elorza at amd.com>;
> Michal Simek <michal.simek at amd.com>; Dmitry Rokosov
> <ddrokosov at salutedevices.com>; Jonas Karlman <jonas at kwiboo.se>; Sebastian
> Reichel <sebastian.reichel at collabora.com>; Meng, Tingting
> <tingting.meng at altera.com>; Chee, Tien Fong <tien.fong.chee at altera.com>;
> Hea, Kok Kiang <kok.kiang.hea at altera.com>; Ng, Boon Khai
> <boon.khai.ng at altera.com>; Yuslaimi, Alif Zakuan
> <alif.zakuan.yuslaimi at altera.com>; Zamri, Muhammad Hazim Izzat
> <muhammad.hazim.izzat.zamri at altera.com>; Lim, Jit Loon
> <jit.loon.lim at altera.com>; Tang, Sieu Mun <sieu.mun.tang at altera.com>
> Subject: Re: [resend v2 06/13] drivers: i3c: Add i3c sandbox simple test.
> 
> On Fri, Mar 14, 2025 at 12:08:55PM +0800, dinesh.maniyam at altera.com wrote:
> 
> > From: Dinesh Maniyam <dinesh.maniyam at altera.com>
> >
> > Add s simple test for the I3C uclass in sandbox.
> >
> > Signed-off-by: Dinesh Maniyam <dinesh.maniyam at altera.com>
> [snip]
> > diff --git a/drivers/i3c/sandbox_i3c.c b/drivers/i3c/sandbox_i3c.c new
> > file mode 100755 index 00000000000..99ce769988d
> > --- /dev/null
> > +++ b/drivers/i3c/sandbox_i3c.c
> > @@ -0,0 +1,58 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (C) 2025 Altera Corporation <www.altera.com>  */
> > +
> > +#include <dm.h>
> > +#include <errno.h>
> > +#include <i3c.h>
> > +#include <linux/i3c/master.h>
> > +
> > +DECLARE_GLOBAL_DATA_PTR;
> 
> Here and elsewhere in the series, audit for adding DECLARE_GLOBAL_DATA_PTR
> without a "gd->" in the code.
> 
> --
> Tom

Apologies. I shall remove the DECLARE_GLOBAL_DATA_PTR 
because there is no usage of gd-> in the code.
Thanks.

Dinesh


More information about the U-Boot mailing list