[PATCH] ARM: socfpga: Drop incorrect imply SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION*

[Tom Rini]

On Tue, Mar 18, 2025 at 03:11:44AM +0000, Chee, Tien Fong wrote:
> Hi Tony,
> 
> > -----Original Message-----
> > From: Tom Rini <trini at konsulko.com>
> > Sent: Saturday, March 15, 2025 9:29 AM
> > To: u-boot at lists.denx.de
> > Cc: Chee, Tien Fong <tien.fong.chee at altera.com>
> > Subject: [PATCH] ARM: socfpga: Drop incorrect imply
> > SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION*
> > 
> > The use of both "imply
> > SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION" and "imply
> > SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION_TYPE" here is wrong
> > as those are both part of the same choice statement. Furthermore you
> > cannot select/imply something from a choice statement, it must be a
> > "default ...
> > if ..." construct within the choice statement in question.
> 
> I think the imply here which allows for overwritten in defconfig.

It doesn't. The specific warning is that these imply statements have no
effect.

> To support the "default....if...", new config for platform specific in
> Kconfig is required. Is there any other approach better to support
> this?

Adding "default SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION if ..." to the
choice statement is fine. But the follow-up question is if it's
something worth being listed like that compared with just being set as
needed in the defconfig.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250318/787ba1b2/attachment.sig>