[EXTERNAL] Re: [RFC PATCH v3 1/5] cmd: fuse: Remove custom string functions

[Tom Rini]

On Tue, Mar 18, 2025 at 09:38:59PM +0530, Harsha Vardhan V M wrote:
> 
> 
> On 18/03/25 19:39, Tom Rini wrote:
> > On Tue, Mar 18, 2025 at 04:20:43PM +0530, Harsha Vardhan V M wrote:
> > 
> > > Remove custom string functions and replace them with normal string
> > > functions. Remove the custom strtou32 and replace it with
> > > simple_strtoul.
> > > 
> > > Signed-off-by: Harsha Vardhan V M <h-vm at ti.com>
> > [snip]
> > > @@ -54,14 +43,18 @@ static int do_fuse(struct cmd_tbl *cmdtp, int flag, int argc,
> > >   	argc -= 2 + confirmed;
> > >   	argv += 2 + confirmed;
> > > -	if (argc < 2 || strtou32(argv[0], 0, &bank) ||
> > > -			strtou32(argv[1], 0, &word))
> > > +	if (argc < 2)
> > >   		return CMD_RET_USAGE;
> > > +	bank = (u32)simple_strtoul(argv[0], NULL, 0);
> > 
> > Do we really need these casts?
> > 
> 
> Not really, Just added them to make it explicit.
> I can remove the casts if that's preferred.

Yes, please drop the casts throughout and post the next iteration as
non-RFC, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250318/7ce324b8/attachment.sig>