[PATCH 1/2] arc: Rework Kconfig choice menus

[Alexey Brodkin]

Hi Tom,

> Currently we get a number of warnings about using "select" statements
> on "choice" options and that this as no effect. Rework some of these so
> that we use "depends on" rather than select for the CPU, and have the
> CPU select the MMU version. The MMU version is no longer prompted for.

Thanks a lot for these fixes.

I'm wondering though if these warnings only have started to appear recently,
i.e. how come we haven't notice them before?

> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
> Cc: Alexey Brodkin <alexey.brodkin at synopsys.com>
> Cc: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
> Cc: uboot-snps-arc at synopsys.com
> ---
>  arch/arc/Kconfig | 22 ++++++----------------
>  1 file changed, 6 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
> index 6ae66bb163c0..be9774dc2896 100644
> --- a/arch/arc/Kconfig
> +++ b/arch/arc/Kconfig
> @@ -66,28 +66,20 @@ config CPU_ARCHS38
>
>  endchoice
>
> -choice
> -       prompt "MMU Version"
> -       default ARC_MMU_V3 if CPU_ARC770D
> -       default ARC_MMU_V2 if CPU_ARC750D
> -       default ARC_MMU_ABSENT if CPU_ARCEM6
> -       default ARC_MMU_ABSENT if CPU_ARCHS36
> -       default ARC_MMU_V4 if CPU_ARCHS38

Well, here the idea was that some users may want to override
MMU settings for their particular SoC/design. See ARC cores are very
configurable and it's possible to mix and match certain components.

For example, it's possible to start from a full-blown ARC770 and
deconfigure MMU from it, effectively getting something like ARC725,
but not exactly as some other properties of ARC770 will still be in place
as opposed to a true ARC725.

Thus we used to have a "default" which comes with a particular template
(ARC770D for example) with ability to override it.

>  config ARC_MMU_ABSENT
> -       bool "No MMU"
> +       bool

I thought that comment of these "bool" values will be seen in "menuconfig" GUI
helping a user to see what's that...

[snip]

>  config ARC_MMU_VER
>          int
>          default 0 if ARC_MMU_ABSENT
> @@ -172,14 +162,14 @@ config TARGET_AXS103
>
>  config TARGET_EMSDP
>          bool "Synopsys EM Software Development Platform"
> -       select CPU_ARCEM6
> +       depends on CPU_ARCEM6

Here we had "select" because this particualr board (EM Software Development Platform)
does come with ARC EM6 CPU, and so I though that selection of the board enforces use
of the processor. But maybe I'm wrong here i nhow that's meant to be implemented
properly.

-Alexey
________________________________
From: Tom Rini <trini at konsulko.com>
Sent: Saturday, March 15, 2025 1:29 AM
To: u-boot at lists.denx.de <u-boot at lists.denx.de>
Cc: Alexey Brodkin <abrodkin at synopsys.com>; Eugeniy Paltsev <paltsev at synopsys.com>; uboot-snps-arc at synopsys.com <uboot-snps-arc at synopsys.com>
Subject: [PATCH 1/2] arc: Rework Kconfig choice menus

Currently we get a number of warnings about using "select" statements
on "choice" options and that this as no effect. Rework some of these so
that we use "depends on" rather than select for the CPU, and have the
CPU select the MMU version. The MMU version is no longer prompted for.

Signed-off-by: Tom Rini <trini at konsulko.com>
---
Cc: Alexey Brodkin <alexey.brodkin at synopsys.com>
Cc: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
Cc: uboot-snps-arc at synopsys.com
---
 arch/arc/Kconfig | 22 ++++++----------------
 1 file changed, 6 insertions(+), 16 deletions(-)

diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
index 6ae66bb163c0..be9774dc2896 100644
--- a/arch/arc/Kconfig
+++ b/arch/arc/Kconfig
@@ -66,28 +66,20 @@ config CPU_ARCHS38

 endchoice

-choice
-       prompt "MMU Version"
-       default ARC_MMU_V3 if CPU_ARC770D
-       default ARC_MMU_V2 if CPU_ARC750D
-       default ARC_MMU_ABSENT if CPU_ARCEM6
-       default ARC_MMU_ABSENT if CPU_ARCHS36
-       default ARC_MMU_V4 if CPU_ARCHS38
-
 config ARC_MMU_ABSENT
-       bool "No MMU"
+       bool
         help
           No MMU

 config ARC_MMU_V2
-       bool "MMU v2"
+       bool
         depends on CPU_ARC750D
         help
           Fixed the deficiency of v1 - possible thrashing in memcpy sceanrio
           when 2 D-TLB and 1 I-TLB entries index into same 2way set.

 config ARC_MMU_V3
-       bool "MMU v3"
+       bool
         depends on CPU_ARC770D
         help
           Introduced with ARC700 4.10: New Features
@@ -95,13 +87,11 @@ config ARC_MMU_V3
           Shared Address Spaces (SASID)

 config ARC_MMU_V4
-       bool "MMU v4"
+       bool
         depends on CPU_ARCHS38
         help
           Introduced as a part of ARC HS38 release.

-endchoice
-
 config ARC_MMU_VER
         int
         default 0 if ARC_MMU_ABSENT
@@ -172,14 +162,14 @@ config TARGET_AXS103

 config TARGET_EMSDP
         bool "Synopsys EM Software Development Platform"
-       select CPU_ARCEM6
+       depends on CPU_ARCEM6

 config TARGET_HSDK
         bool "Support Synopsys HSDK or HSDK-4xD board"

 config TARGET_IOT_DEVKIT
         bool "Synopsys Brite IoT Development kit"
-       select CPU_ARCEM6
+       depends on CPU_ARCEM6

 endchoice

--
2.43.0