[PATCH 00/10] clk: imx: Use Clock framework to register UART clocks

[Fabio Estevam]

On Tue, Mar 18, 2025 at 8:42 PM Adam Ford <aford173 at gmail.com> wrote:
>
> Currenty, most peripherals enable/disable their respecive clocks using
> the clock framework, but serial ports various imx platsforms do not.  Some
> of the newer NXP SoC's register the UART clocks, but they are not necessarily
> associated the to serial_mxc driver, so these clocks need to be manually
> enabled.  Even when the driver model enumerates the UART, the driver model
> doesn't always reflect the proper clock state, because these clocks are not
> controlled by the serial driver.
>
> This series does a few things:

Still fails:
https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/1068998/raw

       arm:  +   kp_imx6q_tpc
+drivers/clk/imx/clk-imx6q.c: In function 'imx6q_clk_probe':
+drivers/clk/imx/clk-imx6q.c:83:51: error: expected ')' before '{' token
+   83 |         if (of_machine_is_compatible("fsl,imx6qp") {
+      |            ~                                      ^~
+      |                                                   )
+drivers/clk/imx/clk-imx6q.c:83:9: note: '-Wmisleading-indentation' is
disabled from this point onwards, since column-tracking was disabled
due to the size of the code/headers
+      |         ^~
+drivers/clk/imx/clk-imx6q.c:83:9: note: adding '-flarge-source-files'
will allow for more column-tracking support, at the expense of
compilation time and memory
+drivers/clk/imx/clk-imx6q.c:179:1: error: expected declaration or
statement at end of input
+  179 | };
+      | ^
+drivers/clk/imx/clk-imx6q.c: At top level:
+drivers/clk/imx/clk-imx6q.c:41:12: error: 'imx6q_clk_probe' defined
but not used [-Werror=unused-function]
+   41 | static int imx6q_clk_probe(struct udevice *dev)
+      |            ^~~~~~~~~~~~~~~
+drivers/clk/imx/clk-imx6q.c:39:26: error: 'ecspi_sels' defined but
not used [-Werror=unused-const-variable=]
+   39 | static const char *const ecspi_sels[] = { "pll3_60m", "osc", };
+      |                          ^~~~~~~~~~
+drivers/clk/imx/clk-imx6q.c:38:26: error: 'uart_sels' defined but not
used [-Werror=unused-const-variable=]
+   38 | static const char *const uart_sels[] = { "pll3_80m", "osc", };
+      |                          ^~~~~~~~~
+drivers/clk/imx/clk-imx6q.c:36:26: error: 'periph_pre_sels' defined
but not used [-Werror=unused-const-variable=]
+   36 | static const char *const periph_pre_sels[] = { "pll2_bus",
"pll2_pfd2_396m",
+      |                          ^~~~~~~~~~~~~~~
+drivers/clk/imx/clk-imx6q.c:35:26: error: 'periph_sels' defined but
not used [-Werror=unused-const-variable=]
+   35 | static const char *const periph_sels[]  = { "periph_pre",
"periph_clk2", };
+      |                          ^~~~~~~~~~~
+drivers/clk/imx/clk-imx6q.c:26:23: error: 'imx6q_clk_ops' defined but
not used [-Werror=unused-variable]
+   26 | static struct clk_ops imx6q_clk_ops = {
+      |                       ^~~~~~~~~~~~~
+cc1: all warnings being treated as errors
+make[4]: *** [scripts/Makefile.build:257: drivers/clk/imx/clk-imx6q.o] Error 1
+make[3]: *** [scripts/Makefile.build:398: drivers/clk/imx] Error 2
+make[2]: *** [scripts/Makefile.build:398: drivers/clk] Error 2
+make[1]: *** [Makefile:1917: drivers] Error 2
+make: *** [Makefile:177: sub-make] Error 2