[PATCH 09/17] test/py: Add a test image for Ubuntu

[Simon Glass]

Hi Tom,

On Wed, 19 Mar 2025 at 16:35, Tom Rini <trini at konsulko.com> wrote:
>
> On Wed, Mar 19, 2025 at 03:04:28PM +0000, Simon Glass wrote:
> > Hi Tom,
> >
> > On Wed, 19 Mar 2025 at 15:52, Tom Rini <trini at konsulko.com> wrote:
> > >
> > > On Wed, Mar 19, 2025 at 03:38:03PM +0100, Simon Glass wrote:
> > >
> > > > Add an extlinux image that contains a few Ubuntu entries.
> > > >
> > > > Increase the number of sandbox-USB-hub ports to permit this.
> > > >
> > > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > >
> > > I don't understand what this test adds. In neither the current Fedora
> > > test nor in this new test are we actually booting something, we're just
> > > taking a sample extlinux.conf and making sure it doesn't fail. Is it
> > > that we're testing in a useful fashion now having two labels?
> >
> > I didn't think so either, which is why I never did this before. But it
> > turns out that there were some bugs, too.
>
> I don't understand you, sorry. You don't think so either to what?

I didn't think we needed two extlinux examples on different boot
devices, but we do.

>
> > > We should probably be clear about what we're doing in the tests and
> > > instead of adding seemingly arbitrary distributions add an extlinux test
> > > and testcases.
> >
> > This is not actually a test case. It is simply creating a new image.
> > The test cases are in the other patches, so please take a look there.
>
> Nothing in this series quickly reads as adding tests and fixing problems
> with extlinux parsing, it's all bootmeth stuff?

It isn't about the actual parsing of the .conf file, although I would
like to add tests there as we have none apart from what I have added
in my PXE series. It's more about having multiple devices with
bootable OSes on them. This series tidies up and fixes this. We need
to have an image available on more than one device to spot these
problems.

Currently we have two accessible to sandbox, one extlinux and one
EFI*. I decided to add a third, using extlinux.

Again, this is not a test case, but provides an image for the test
cases in this series.

Regards,
Simon

* The boot_efi() test in your tree is only a subset of the full test,
as you know