回复: [PATCH v7 10/19] imx9: scmi: add i.MX95 SoC and clock related code

[Alice Guo (OSS)]

> -----邮件原件-----
> 发件人: Lothar Waßmann <LW at KARO-electronics.de>
> 发送时间: 2025年3月6日 13:42
> 收件人: Alice Guo (OSS) <alice.guo at oss.nxp.com>
> 抄送: Tom Rini <trini at konsulko.com>; Lukasz Majewski <lukma at denx.de>;
> Sean Anderson <seanga2 at gmail.com>; Simon Glass <sjg at chromium.org>;
> Stefano Babic <sbabic at denx.de>; Fabio Estevam <festevam at gmail.com>;
> dl-uboot-imx <uboot-imx at nxp.com>; Alper Nebi Yasak
> <alpernebiyasak at gmail.com>; Alice Guo <alice.guo at nxp.com>;
> marex at denx.de; u-boot at lists.denx.de; Peng Fan <peng.fan at nxp.com>; Ye Li
> <ye.li at nxp.com>
> 主题: Re: [PATCH v7 10/19] imx9: scmi: add i.MX95 SoC and clock related code
> 
> [You don't often get email from lw at karo-electronics.de. Learn why this is
> important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> Hi,
> 
> On Wed, 05 Mar 2025 21:28:22 +0800 Alice Guo (OSS) wrote:
> > From: Peng Fan <peng.fan at nxp.com>
> >
> > This patch adds i.MX95 SoC and clock related code. Because they are
> > based on SCMI, put them in the scmi subfolder.
> >
> > Signed-off-by: Ye Li <ye.li at nxp.com>
> > Signed-off-by: Peng Fan <peng.fan at nxp.com>
> > Signed-off-by: Alice Guo <alice.guo at nxp.com>
> > Reviewed-by: Peng Fan <peng.fan at nxp.com>
> > ---
> >  arch/arm/include/asm/arch-imx/cpu.h        |   2 +
> >  arch/arm/include/asm/arch-imx9/clock.h     |  10 +
> >  arch/arm/include/asm/arch-imx9/imx-regs.h  |   5 +
> >  arch/arm/include/asm/arch-imx9/sys_proto.h |   1 +
> >  arch/arm/include/asm/mach-imx/sys_proto.h  |  39 ++
> >  arch/arm/mach-imx/imx9/scmi/Makefile       |   6 +
> >  arch/arm/mach-imx/imx9/scmi/clock.c        | 105 ++++
> >  arch/arm/mach-imx/imx9/scmi/clock_scmi.c   | 133 +++++
> >  arch/arm/mach-imx/imx9/scmi/soc.c          | 788
> +++++++++++++++++++++++++++++
> >  arch/sandbox/include/asm/scmi_test.h       |   2 +-
> >  10 files changed, 1090 insertions(+), 1 deletion(-)
> >
> [...]
> > diff --git a/arch/arm/mach-imx/imx9/scmi/clock.c
> b/arch/arm/mach-imx/imx9/scmi/clock.c
> > new file mode 100644
> > index 0000000000..9ebd380976
> > --- /dev/null
> > +++ b/arch/arm/mach-imx/imx9/scmi/clock.c
> > @@ -0,0 +1,105 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright 2025 NXP
> > + */
> > +
> > +#include <asm/arch/clock.h>
> > +#include <dm/uclass.h>
> > +#include <scmi_agent.h>
> > +#include "../../../../../dts/upstream/src/arm64/freescale/imx95-clock.h"
> >
> "Interesting" include path...
> Shouldn't this file be located under dts/upstream/include/dt-bindings/ like all the
> other imx*-clock.h files?
> Then the file should be picked up via
> #include <dt-bindings/imx95-clock.h>

Hi,

imx95-clock.h is not in this directory dts/upstream/include/dt-bindings/.

Best Regards,
Alice Guo