回复: 回复: 回复: 回复: 回复: 回复: [PATCH v4 04/20] firmware: scmi: add pin control protocol support to SCMI agent

[Alice Guo (OSS)]

> -----邮件原件-----
> 发件人: Marek Vasut <marex at denx.de>
> 发送时间: 2025年3月20日 12:04
> 收件人: Alice Guo (OSS) <alice.guo at oss.nxp.com>; Peng Fan (OSS)
> <peng.fan at oss.nxp.com>
> 抄送: Tom Rini <trini at konsulko.com>; Stefano Babic <sbabic at denx.de>; Fabio
> Estevam <festevam at gmail.com>; dl-uboot-imx <uboot-imx at nxp.com>; Lukasz
> Majewski <lukma at denx.de>; Sean Anderson <seanga2 at gmail.com>; Simon
> Glass <sjg at chromium.org>; Alper Nebi Yasak <alpernebiyasak at gmail.com>;
> u-boot at lists.denx.de; tharvey at gateworks.com; Alice Guo
> <alice.guo at nxp.com>
> 主题: Re: 回复: 回复: 回复: 回复: 回复: [PATCH v4 04/20] firmware: scmi:
> add pin control protocol support to SCMI agent
> 
> On 3/20/25 3:28 AM, Alice Guo (OSS) wrote:
> 
> Hello Alice,
> 
> >>>> - Basically duplicate the mechanism in 7940a93eb977 ("net: phy:
> >>>> Iterate over both registered PHYs and struct phy_driver linker
> >>>> list"), call it
> >> e.g.
> >>>> U_BOOT_SCMI_DRIVER()
> >>>> - Switch SCMI drivers to use U_BOOT_SCMI_DRIVER , have each one
> >>>> list a protocol ID (instead of the PHY IDs), and then use the
> >>>> scmi_agent-uclass.c to iterate over all the linker lists
> >>>>
> >>>> About the MX95 specifics and handling those, it is possible to have
> >>>> two drivers which support the same hardware compiled into U-Boot
> >>>> and have them decide at bind time which driver should bind and
> >>>> which not, look at drivers/mtd/renesas_rpc_hf.c rpc_hf_probe() and
> >>>> drivers/spi/renesas_rpc_spi.c
> >>>> rpc_spi_bind() for example of doing this.
> >>>>
> >>>> I hope this helps untangle the SCMI implementation.
> >>>
> >>> Thank you for providing the example. Please review my patch set.
> >>> https://patchwork.ozlabs.org/project/uboot/patch/20250305-imx95-v1-2
> >>> -2
> >>> 86d15acbb8a at oss.nxp.com/
> >>> https://patchwork.ozlabs.org/project/uboot/patch/20250305-imx95-v1-3
> >>> -2
> >>> 86d15acbb8a at oss.nxp.com/
> >>
> >> I will try to review this this week, I apologize for the delayed replies.
> >
> > Hi Marek,
> >
> > Are you available this week to review? 😊
> Ugh, sorry, I am working toward it. I apologize for the abysmal delay.
> 
> Thank you for the reminder.

Hi Marek,

I have sent v8. Please review this patch set. The main changes of v7 and v8 are included in cover-letter so that you can know what modifications I have made. Thanks!

Best Regards
Alice Guo