[PATCH 4/8] env: Rename SYS_MMC_ENV_DEV to ENV_SDMMC_DEVICE_INDEX

Quentin Schulz quentin.schulz at cherry.de
Mon Mar 24 13:39:40 CET 2025


Hi Marek,

On 3/22/25 10:55 PM, Marek Vasut wrote:
> Rename the variable and add ENV_ prefix, so that all configuration
> options which are related to environment would have an CONFIG_ENV_
> prefix. No functional change.
> 
> Use ENV_SDMMC_DEVICE_INDEX to clarify this is the SD/MMC device
> index, a number, as enumerated by U-Boot. Update the help text
> accordingly.
> 

I disagree with this part of the rename (MMC->SDMMC), our drivers all 
are using mmc (env/mmc.*, drivers/mmc/*, cmd/mmc.c, ...) for both SD and 
MMC. We also have ENV_IS_IN_MMC which is for both. I don't think it's 
worth the confusion.

SYS_ prefix to ENV_ is fine though!

DEVICE_INDEX could be DEV_IDX too if we want to shorten the symbol name.

Cheers,
Quentin


More information about the U-Boot mailing list