[PATCH 4/8] env: Rename SYS_MMC_ENV_DEV to ENV_SDMMC_DEVICE_INDEX

[Tom Rini]

On Wed, Mar 26, 2025 at 12:02:08AM +0100, Marek Vasut wrote:
> On 3/24/25 1:39 PM, Quentin Schulz wrote:
> > Hi Marek,
> 
> Hi,
> 
> > On 3/22/25 10:55 PM, Marek Vasut wrote:
> > > Rename the variable and add ENV_ prefix, so that all configuration
> > > options which are related to environment would have an CONFIG_ENV_
> > > prefix. No functional change.
> > > 
> > > Use ENV_SDMMC_DEVICE_INDEX to clarify this is the SD/MMC device
> > > index, a number, as enumerated by U-Boot. Update the help text
> > > accordingly.
> > > 
> > 
> > I disagree with this part of the rename (MMC->SDMMC), our drivers all
> > are using mmc (env/mmc.*, drivers/mmc/*, cmd/mmc.c, ...) for both SD and
> > MMC. We also have ENV_IS_IN_MMC which is for both. I don't think it's
> > worth the confusion.
> 
> My main problem is, that it is confusing to call everything _mmc_ even if
> most of it also applies to SD . There is no way to discern parts which are
> MMC specific from parts which are common to SD and MMC now.

Do we have support for anything using the MMC part of the standard that
is not storage? I certainly agree it's confusingly named atm, but I
think changing some parts but not other parts will make it worse, not
better.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250325/c90d7085/attachment.sig>