[PATCH] net: lwip: Remove error print on failed tx

[Jerome Forissier]

On 3/26/25 09:28, Ilias Apalodimas wrote:
> When an ethernet driver fails to send a frame we print an error in lwIP.
> But depending on how often that error is it might significantly delay
> transmissions.
> 
> For example downloading a big file with the rpi4 spams the console with
> 'send error: -101', but removing the print makes the file download with
> an average speed of ~8.5MiB/s since the packets are retransmitted.
> 
> So let's move it to a 'debug' in lwIP and expect ethernet drivers to handle
> the failure if it's severe.
> 
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>
> ---
>  net/lwip/net-lwip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Jerome Forissier <jerome.forissier at linaro.org>

Thanks,
-- 
Jerome

> diff --git a/net/lwip/net-lwip.c b/net/lwip/net-lwip.c
> index c00a7fe97cd6..6b7b696dbf0f 100644
> --- a/net/lwip/net-lwip.c
> +++ b/net/lwip/net-lwip.c
> @@ -57,7 +57,7 @@ static err_t net_lwip_tx(struct netif *netif, struct pbuf *p)
>  	err = eth_get_ops(udev)->send(udev, pp ? pp : p->payload, p->len);
>  	free(pp);
>  	if (err) {
> -		log_err("send error %d\n", err);
> +		debug("send error %d\n", err);
>  		return ERR_ABRT;
>  	}
> 
> --
> 2.47.2
>