[PATCH v3 21/31] rockchip: rk3399: Adjust initial TPL-stack to match SPL
Jonas Karlman
jonas at kwiboo.se
Fri Mar 28 18:28:37 CET 2025
Hi Simon,
On 2025-03-28 16:35, Simon Glass wrote:
> There doesn't seem to be a good reason to use a different value for TPL
> than SPL.
This reference to SPL stack addr is still a little bit confusing, all
RK3399 boards now use a SPL stack addr in DRAM and not i SRAM.
So SPL and TPL stack addr will continue to use a different addr after
this patch.
Regards,
Jonas
> Change the TPL value, since it allows a 256-byte bloblist to
> be safely located above the stack in all phases.
>
> Note that for most boards, SDRAM init happens in TPL so the SPL stack
> ends up in DRAM, at address CONFIG_SPL_STACK_R_ADDR.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - Reword commit to mention comments from Jonas
>
> arch/arm/mach-rockchip/rk3399/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/rk3399/Kconfig b/arch/arm/mach-rockchip/rk3399/Kconfig
> index fc55b498111..8064b6286fc 100644
> --- a/arch/arm/mach-rockchip/rk3399/Kconfig
> +++ b/arch/arm/mach-rockchip/rk3399/Kconfig
> @@ -159,7 +159,7 @@ config TPL_LDSCRIPT
> default "arch/arm/mach-rockchip/u-boot-tpl-v8.lds"
>
> config TPL_STACK
> - default 0xff8effff
> + default 0xff8eff00
>
> config TPL_TEXT_BASE
> default 0xff8c2000
More information about the U-Boot
mailing list