[PATCH v3 19/31] rockchip: Provide a VPL phase on rk3399

[Tom Rini]

On Fri, Mar 28, 2025 at 11:40:01PM +0000, Simon Glass wrote:
> Hi Tom,
> 
> On Fri, 28 Mar 2025 at 10:16, Jonas Karlman <jonas at kwiboo.se> wrote:
> >
> > Hi Simon,
> >
> > On 2025-03-28 16:34, Simon Glass wrote:
> > > Add support for this new phase, which runs after TPL. It determines the
> > > state of the machine, then selects which SPL image to use. SDRAM init is
> > > then done in SPL, so that it is updatable.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > > ---
> > >
> > > (no changes since v2)
> > >
> > > Changes in v2:
> > > - Rewrite help for VPL_ROCKCHIP_COMMON_BOARD
> > > - Skip spl-boot-order.c for VPL (rather than modifying it)
> > >
> > >  arch/arm/include/asm/spl.h               |   1 +
> > >  arch/arm/mach-rockchip/Kconfig           |  25 +++++-
> > >  arch/arm/mach-rockchip/Makefile          |  11 ++-
> > >  arch/arm/mach-rockchip/rk3399/Kconfig    |   9 ++
> > >  arch/arm/mach-rockchip/spl.c             |   3 +
> > >  arch/arm/mach-rockchip/tpl.c             |   2 +-
> > >  arch/arm/mach-rockchip/u-boot-vpl-v8.lds | 107 +++++++++++++++++++++++
> > >  arch/arm/mach-rockchip/vpl.c             |  53 +++++++++++
> > >  common/spl/Kconfig                       |   1 +
> > >  9 files changed, 205 insertions(+), 7 deletions(-)
> > >  create mode 100644 arch/arm/mach-rockchip/u-boot-vpl-v8.lds
> > >  create mode 100644 arch/arm/mach-rockchip/vpl.c
> > >
> >
> > This patch and therefore this series does not apply to the next branch.
> >
> > Are there any depends that are missing or are you only testing based on
> > your own fork?
> 
> Until we are ready to apply things, yes I am using the sjg tree. See
> the tags in the cover letters of patches I send. For this one it is:
> 
> base-commit: 3f76d803db9b500f43bc534465945a8d2836bb3e
> branch: vbi3
> 
> So no, there is nothing else that this series depends on and if you
> can review it I can send a PR for Tom for -next one all necessary
> changes are made.

If you want something to be reviewed you need to base it on next and not
your tree. Your experiment with posting stuff on top of your own tree is
already making other members of the community have trouble reviewing
your code and they should not be expected to look in your own tree to
have to test changes as that's wasting their time.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250328/8b252a04/attachment.sig>