[PATCH v2 2/3] tegra: respect CONFIG_TEGRA_ENABLE_UART* options on Transformer T20

[Svyatoslav Ryhel]

нд, 30 бер. 2025 р. о 22:27 Artur Kowalski <arturkow2000 at gmail.com> пише:
>
> If debug UART is set to anything other than UARTD, U-Boot's SPL hangs
> trying to communicate with UARTD which clock won't be ungated. With this
> patch it is possible to boot with UARTA enabled.
>
> Signed-off-by: Artur Kowalski <arturkow2000 at gmail.com>
> ---
>
> (no changes since v1)
>
>  include/configs/transformer-t20.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/include/configs/transformer-t20.h b/include/configs/transformer-t20.h
> index 6a3d9b24036..d3a98cc5a70 100644
> --- a/include/configs/transformer-t20.h
> +++ b/include/configs/transformer-t20.h
> @@ -16,7 +16,17 @@
>  #define CFG_TEGRA_BOARD_STRING         "ASUS Transformer"
>
>  /* Board-specific serial config */
> +#if defined(CONFIG_TEGRA_ENABLE_UARTA)
> +#define CFG_SYS_NS16550_COM1           NV_PA_APB_UARTA_BASE
> +#elif defined(CONFIG_TEGRA_ENABLE_UARTB)
> +#define CFG_SYS_NS16550_COM1           NV_PA_APB_UARTB_BASE
> +#elif defined(CONFIG_TEGRA_ENABLE_UARTC)
> +#define CFG_SYS_NS16550_COM1           NV_PA_APB_UARCD_BASE
> +#elif defined(CONFIG_TEGRA_ENABLE_UARTD)
>  #define CFG_SYS_NS16550_COM1           NV_PA_APB_UARTD_BASE
> +#elif defined(CONFIG_TEGRA_ENABLE_UARTE)
> +#define CFG_SYS_NS16550_COM1           NV_PA_APB_UARTE_BASE
> +#endif
>

Here you are actually hitting much much deeper thing. You are applying
fix to the result, not the cause. Adjustment should be done in the
tegra board itself with amending all existing tegra boards. As a
maintainer I cannot insist on you doing this unless you willingly
agree. You have time to answer till 02.03.25 and if no answer I will
apply patch on my own to custodian tegra/staging branch.

>  #include "tegra-common-post.h"
>
> --
> 2.48.1
>