[PATCH v1 1/1] sysreset: add PHASE_ to GPIO reset and poweroff configs

[Quentin Schulz]

Hi Svyatoslav,

On 3/30/25 11:28 AM, Svyatoslav Ryhel wrote:
> GPIO reset and power-off functionality depends on device tree data, which
> is often absent in SPL or TPL. To address this, incorporate PHASE_ into the
> config option.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95 at gmail.com>
> ---
>   drivers/sysreset/Makefile | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/sysreset/Makefile b/drivers/sysreset/Makefile
> index 796fc9effa5..ded91a4d325 100644
> --- a/drivers/sysreset/Makefile
> +++ b/drivers/sysreset/Makefile
> @@ -8,8 +8,8 @@ obj-$(CONFIG_ARCH_ROCKCHIP) += sysreset_rockchip.o
>   obj-$(CONFIG_ARCH_STI) += sysreset_sti.o
>   obj-$(CONFIG_SANDBOX) += sysreset_sandbox.o
>   obj-$(CONFIG_SYSRESET_CV1800B) += sysreset_cv1800b.o
> -obj-$(CONFIG_POWEROFF_GPIO) += poweroff_gpio.o
> -obj-$(CONFIG_SYSRESET_GPIO) += sysreset_gpio.o
> +obj-$(CONFIG_$(PHASE_)POWEROFF_GPIO) += poweroff_gpio.o
> +obj-$(CONFIG_$(PHASE_)SYSRESET_GPIO) += sysreset_gpio.o

Are you sure this is safe for all boards?

Essentially, right now POWEROFF_GPIO/SYSRESET_GPIO would be built for 
devices with TPL/SPL_SYSRESET symbol enabled, but with this change it 
would be disabled, possibly breaking their setup.

I'm not against this change, it's just that there may be additional 
changes made to defconfigs to transition to this new symbol...

... which you haven't added here. I don't know what's the policy, but I 
think it makes sense to add the VPL/TPL/SPL symbols here so that people 
can simply enable the symbols whenever they need it enabled in the phase 
instead of needing to send another patch before doing that.

Cheers,
Quentin