[PATCH 07/17] bootstd: Fully complete iteration of a uclass

Tom Rini trini at konsulko.com
Mon Mar 31 19:41:17 CEST 2025


On Wed, Mar 19, 2025 at 03:38:01PM +0100, Simon Glass wrote:

> When trying all bootdevs in a uclass, the method flags are not preserved
> in the iterator.
> 
> This has no impact on the first bootdev, since that is the one which
> sets the flags. For the next one, iter_inc() is used and it finds the
> next bootdev. However it sets the method_flags to 0
> 
> The result is that the third scan is conducted without the required
> BOOTFLOW_METHF_SINGLE_UCLASS flag, so iteration procees to the next
> label. This can miss bootdevs if there three or more USB-storage
> devices, for example.
> 
> Fix this by keeping the method flags around in this case.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>

This seems like a real bugfix and a fixes tag would help make it clear
what it applies to.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250331/e68e9917/attachment.sig>


More information about the U-Boot mailing list