[PATCH] sama5d27: Fix the 'reset' command

Mon Mar 31 22:31:33 CEST 2025

On 3/31/25 21:04, Fabio Estevam wrote:
> From: Fabio Estevam <festevam at denx.de>
> 
> Since commit 61040097a9d1 ("reset: at91: Add reset driver for basic
> assert/deassert operations") the "atmel,sama5d3-rstc" compatible for
> the sama5d2 reset controller in sama5d2.dtsi is not handled by
> CONFIG_SYSRESET_AT91 anymore, but by CONFIG_RESET_AT91 now.
> 
> This resulted in the following error, when trying to reset from the U-Boot
> shell on a sama5d27_wlsom1 board:
>     
>  => reset
>  resetting ...
>  System reset not supported on this platform
>  ### ERROR ### Please RESET the board ###
> 
> Fix it by enabling the CONFIG_RESET_AT91 driver in all sama5d27 defconfigs.
> 
> Tested on a sama5d27_wlsom1 board.
> 
> Based on the fix in commit e1ee52ca56fc ("configs: at91: sam9x60: Switch
> to new reset driver")
> 
> Signed-off-by: Fabio Estevam <festevam at denx.de>
> ---
> Eugen/Tom,
> 
> This is material for 2025.04.

This is something that would happen for a few years now, why the rush ?
There is still time for a fixes PR though .
Can you add a fixes tag then ?

> 
>  configs/sama5d27_giantboard_defconfig          | 2 ++
>  configs/sama5d27_som1_ek_mmc1_defconfig        | 2 ++
>  configs/sama5d27_som1_ek_mmc_defconfig         | 2 ++
>  configs/sama5d27_som1_ek_qspiflash_defconfig   | 2 ++
>  configs/sama5d27_wlsom1_ek_mmc_defconfig       | 2 ++
>  configs/sama5d27_wlsom1_ek_qspiflash_defconfig | 2 ++
>  6 files changed, 12 insertions(+)
> 
> diff --git a/configs/sama5d27_giantboard_defconfig b/configs/sama5d27_giantboard_defconfig
> index ad1621a94dd7..0b7940f4fb43 100644
> --- a/configs/sama5d27_giantboard_defconfig
> +++ b/configs/sama5d27_giantboard_defconfig
> @@ -14,6 +14,7 @@ CONFIG_ENV_SIZE=0x4000
>  CONFIG_DM_GPIO=y
>  CONFIG_DEFAULT_DEVICE_TREE="at91-sama5d27_giantboard"
>  CONFIG_OF_LIBFDT_OVERLAY=y
> +CONFIG_DM_RESET=y
>  CONFIG_SYS_MONITOR_LEN=524288
>  CONFIG_SPL_MMC=y
>  CONFIG_SPL_SERIAL=y
> @@ -84,6 +85,7 @@ CONFIG_DM_SPI_FLASH=y
>  CONFIG_PINCTRL=y
>  CONFIG_SPL_PINCTRL=y
>  CONFIG_PINCTRL_AT91PIO4=y
> +CONFIG_RESET_AT91=y
>  CONFIG_DM_SERIAL=y
>  CONFIG_DEBUG_UART_ANNOUNCE=y
>  CONFIG_ATMEL_USART=y
> diff --git a/configs/sama5d27_som1_ek_mmc1_defconfig b/configs/sama5d27_som1_ek_mmc1_defconfig
> index bb29121bb156..2e5a4acf27d8 100644
> --- a/configs/sama5d27_som1_ek_mmc1_defconfig
> +++ b/configs/sama5d27_som1_ek_mmc1_defconfig
> @@ -14,6 +14,7 @@ CONFIG_ENV_SIZE=0x4000
>  CONFIG_DM_GPIO=y
>  CONFIG_DEFAULT_DEVICE_TREE="at91-sama5d27_som1_ek"
>  CONFIG_OF_LIBFDT_OVERLAY=y
> +CONFIG_DM_RESET=y
>  CONFIG_SYS_MONITOR_LEN=524288
>  CONFIG_SPL_MMC=y
>  CONFIG_SPL_SERIAL=y
> @@ -93,6 +94,7 @@ CONFIG_MACB=y
>  CONFIG_PINCTRL=y
>  CONFIG_SPL_PINCTRL=y
>  CONFIG_PINCTRL_AT91PIO4=y
> +CONFIG_RESET_AT91=y
>  CONFIG_DM_SERIAL=y
>  CONFIG_DEBUG_UART_ANNOUNCE=y
>  CONFIG_ATMEL_USART=y
> diff --git a/configs/sama5d27_som1_ek_mmc_defconfig b/configs/sama5d27_som1_ek_mmc_defconfig
> index 308aafc7dfe5..11a536d714c3 100644
> --- a/configs/sama5d27_som1_ek_mmc_defconfig
> +++ b/configs/sama5d27_som1_ek_mmc_defconfig
> @@ -15,6 +15,7 @@ CONFIG_ENV_SIZE=0x4000
>  CONFIG_DM_GPIO=y
>  CONFIG_DEFAULT_DEVICE_TREE="at91-sama5d27_som1_ek"
>  CONFIG_OF_LIBFDT_OVERLAY=y
> +CONFIG_DM_RESET=y
>  CONFIG_SYS_MONITOR_LEN=524288
>  CONFIG_SPL_MMC=y
>  CONFIG_SPL_SERIAL=y
> @@ -93,6 +94,7 @@ CONFIG_MACB=y
>  CONFIG_PINCTRL=y
>  CONFIG_SPL_PINCTRL=y
>  CONFIG_PINCTRL_AT91PIO4=y
> +CONFIG_RESET_AT91=y
>  CONFIG_DM_SERIAL=y
>  CONFIG_DEBUG_UART_ANNOUNCE=y
>  CONFIG_ATMEL_USART=y
> diff --git a/configs/sama5d27_som1_ek_qspiflash_defconfig b/configs/sama5d27_som1_ek_qspiflash_defconfig
> index ac14dd53838d..86cb5c287be1 100644
> --- a/configs/sama5d27_som1_ek_qspiflash_defconfig
> +++ b/configs/sama5d27_som1_ek_qspiflash_defconfig
> @@ -15,6 +15,7 @@ CONFIG_ENV_SECT_SIZE=0x1000
>  CONFIG_DM_GPIO=y
>  CONFIG_DEFAULT_DEVICE_TREE="at91-sama5d27_som1_ek"
>  CONFIG_OF_LIBFDT_OVERLAY=y
> +CONFIG_DM_RESET=y
>  CONFIG_SYS_MONITOR_LEN=524288
>  CONFIG_SPL_MMC=y
>  CONFIG_SPL_SERIAL=y
> @@ -92,6 +93,7 @@ CONFIG_MACB=y
>  CONFIG_PINCTRL=y
>  CONFIG_SPL_PINCTRL=y
>  CONFIG_PINCTRL_AT91PIO4=y
> +CONFIG_RESET_AT91=y
>  CONFIG_DM_SERIAL=y
>  CONFIG_DEBUG_UART_ANNOUNCE=y
>  CONFIG_ATMEL_USART=y
> diff --git a/configs/sama5d27_wlsom1_ek_mmc_defconfig b/configs/sama5d27_wlsom1_ek_mmc_defconfig
> index 6db27280f0fa..014f0093eee6 100644
> --- a/configs/sama5d27_wlsom1_ek_mmc_defconfig
> +++ b/configs/sama5d27_wlsom1_ek_mmc_defconfig
> @@ -13,6 +13,7 @@ CONFIG_ENV_SIZE=0x4000
>  CONFIG_DM_GPIO=y
>  CONFIG_DEFAULT_DEVICE_TREE="at91-sama5d27_wlsom1_ek"
>  CONFIG_OF_LIBFDT_OVERLAY=y
> +CONFIG_DM_RESET=y
>  CONFIG_SYS_MONITOR_LEN=524288
>  CONFIG_SPL_MMC=y
>  CONFIG_SPL_SERIAL=y
> @@ -99,6 +100,7 @@ CONFIG_MACB=y
>  CONFIG_PINCTRL=y
>  CONFIG_SPL_PINCTRL=y
>  CONFIG_PINCTRL_AT91PIO4=y
> +CONFIG_RESET_AT91=y
>  CONFIG_DM_SERIAL=y
>  CONFIG_DEBUG_UART_ANNOUNCE=y
>  CONFIG_ATMEL_USART=y
> diff --git a/configs/sama5d27_wlsom1_ek_qspiflash_defconfig b/configs/sama5d27_wlsom1_ek_qspiflash_defconfig
> index 765565265165..efe23115f620 100644
> --- a/configs/sama5d27_wlsom1_ek_qspiflash_defconfig
> +++ b/configs/sama5d27_wlsom1_ek_qspiflash_defconfig
> @@ -14,6 +14,7 @@ CONFIG_DM_GPIO=y
>  CONFIG_SPL_DM_SPI=y
>  CONFIG_DEFAULT_DEVICE_TREE="at91-sama5d27_wlsom1_ek"
>  CONFIG_OF_LIBFDT_OVERLAY=y
> +CONFIG_DM_RESET=y
>  CONFIG_SYS_MONITOR_LEN=524288
>  CONFIG_SPL_SERIAL=y
>  CONFIG_SPL_DRIVERS_MISC=y
> @@ -103,6 +104,7 @@ CONFIG_MACB=y
>  CONFIG_PINCTRL=y
>  CONFIG_SPL_PINCTRL=y
>  CONFIG_PINCTRL_AT91PIO4=y
> +CONFIG_RESET_AT91=y
>  CONFIG_DM_SERIAL=y
>  CONFIG_DEBUG_UART_ANNOUNCE=y
>  CONFIG_ATMEL_USART=y