[PATCH 1/2] cmd: mtd: benchmark: use lldiv() instead of 64-bit division
Mikhail Kshevetskiy
mikhail.kshevetskiy at iopsys.eu
Sat Nov 1 07:24:23 CET 2025
As was noted by Heinrich Schuchardt, some SoCs may not support 64-bit
divisions. Fix an issue by using lldiv() instead.
The code assumes that the benchmark never takes more than 4294 seconds
and thus the difference will be less than U32_MAX.
Also replace (speed / 1024) by (speed >> 10) to avoid potential 64-bit
division.
Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy at iopsys.eu>
---
cmd/mtd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/cmd/mtd.c b/cmd/mtd.c
index d0072129659..7f25144098b 100644
--- a/cmd/mtd.c
+++ b/cmd/mtd.c
@@ -10,6 +10,7 @@
#include <command.h>
#include <console.h>
+#include <div64.h>
#include <led.h>
#if CONFIG_IS_ENABLED(CMD_MTD_OTP)
#include <hexdump.h>
@@ -595,10 +596,10 @@ static int do_mtd_io(struct cmd_tbl *cmdtp, int flag, int argc,
if (benchmark && bench_start) {
bench_end = timer_get_us();
- speed = (len * 1000000) / (bench_end - bench_start);
+ speed = lldiv(len * 1000000, bench_end - bench_start);
printf("%s speed: %lukiB/s\n",
read ? "Read" : "Write",
- (unsigned long)(speed / 1024));
+ (unsigned long)(speed >> 10));
}
led_activity_off();
--
2.51.0
More information about the U-Boot
mailing list