Re: [PATCH] Revert "power: regulator: Add vin-supply for GPIO and Fixed regulators"

[Dragan Simic]

Hello Jonas,

On Sunday, November 02, 2025 03:00 CET, Jonas Karlman <jonas at kwiboo.se> wrote:
> On 11/1/2025 10:23 PM, Dragan Simic wrote:
> > On Saturday, November 01, 2025 22:17 CET, Mark Kettenis <mark.kettenis at xs4all.nl> wrote:
> >>> From: Jonas Karlman <jonas at kwiboo.se>
> >>>
> >>> Rockchip boards may depend on a working MMC regulator in SPL to
> >>> successfully load FIT payload from MMC. Typically, these boards only
> >>> include the vmmc-supply regulator and not its vin-supply in SPL control
> >>> FDT.
> >>>
> >>> The commit f98d812e5353 ("power: regulator: Add vin-supply for GPIO and
> >>> Fixed regulators") breaks loading FIT from MMC in SPL on some of these
> >>> boards due to now requiring the vin-supply to be included in the SPL
> >>> control FDT.
> >>
> >> I ran into this issue a few days ago.  Unfortunately that means U-Boot
> >> 2025.10 is broken on several Rockchip boards :(.
> > 
> > Sadly, that's true. :(
> 
> I do not think the commit was part of 2025.10, it was merged to next and
> should currently only be part of master and 2026.01-rc1.

You're right, the troublesome commit f98d812e5353 ("power:
regulator: Add vin-supply for GPIO and Fixed regulators") isn't
part of the U-Boot 2025.10 release, which can be verified by
checking drivers/power/regulator/regulator_common.c in the
ultimate reference, which is the 2025.10 release tarball. [1]

[1] https://ftp.denx.de/pub/u-boot/u-boot-2025.10.tar.bz2