Re: 回复: [PATCH v3] firmware: scmi: Add clock v3.2 CONFIG_SET support

[Marek Vasut]

On 11/4/25 4:56 AM, Alice Guo (OSS) wrote:

Hello Alice,

> I tested PATCH v3 on i.MX95, and it works as expected. However, I noticed that PATCH v3 increases runtime memory usage. I'm not sure whether this is a concern we need to address, so I want to discuss it with you. Here is the change I made based on PATCH v2:
> 
> static int scmi_clk_gate(struct clk *clk, int enable)
>   {
> -       struct scmi_clock_priv *priv = dev_get_priv(clk->dev->parent);
> +       struct scmi_clock_priv *priv = clk->dev->parent_priv_;
>          struct scmi_clk_state_in_v1 in_v1 = {
>                  .clock_id = clk_get_id(clk),
>                  .attributes = enable,
> @@ -331,6 +332,7 @@ static int scmi_clk_probe(struct udevice *dev)
>                          }
> 
>                          dev_clk_dm(dev, i, &clk_scmi->clk);
> +                       dev_set_parent_priv(clk_scmi->clk.dev, priv);
> 
>                          if (CLK_HAS_RESTRICTIONS(attributes)) {
>                                  u32 perm;

This is a VERY nice solution, thank you for bringing this up.

I will use that for V4.

-- 
Best regards,
Marek Vasut