[RESEND PATCH v3 1/2] drivers: video: tidss: Refactor tidss_drv

[Tom Rini]

On Wed, Nov 05, 2025 at 10:00:39PM +0530, Swamil Jain wrote:

> - Refactor tidss_drv to improve modularity, enabling support for more
>   display interfaces beyond OLDI in the future
> - Add detection and initialization of active OLDI panels using the DT
> - Port tidss_oldi.c from the upstream Linux kernel oldi series[0] and
>   derive several APIs from it to determine the dual link pixel order
> - Add tidss_oldi_init() and helper routines to handle OLDI-specific
>   setup and move related helper routines to tidss_oldi.c
> 
> [0]: https://lore.kernel.org/all/20250528122544.817829-1-aradhya.bhatia@linux.dev/
> 
> Reviewed-by: Devarsh Thakkar <devarsht at ti.com>
> Signed-off-by: Swamil Jain <s-jain1 at ti.com>
> ---
>  drivers/video/tidss/Makefile     |   2 +-
>  drivers/video/tidss/tidss_drv.c  | 235 +++++++++++++-------
>  drivers/video/tidss/tidss_drv.h  |  40 ++--
>  drivers/video/tidss/tidss_oldi.c | 364 +++++++++++++++++++++++++++++++
>  drivers/video/tidss/tidss_oldi.h |  72 ++++++
>  drivers/video/tidss/tidss_regs.h |  21 --
>  6 files changed, 612 insertions(+), 122 deletions(-)
>  create mode 100644 drivers/video/tidss/tidss_oldi.c
>  create mode 100644 drivers/video/tidss/tidss_oldi.h

You didn't include my feedback about making sure this either builds on
sandbox or updates the Kconfig to have appropriate dependencies. I
checked the build failure more, and we fail to build this on sandbox
(and so allyesconfig) because <asm/utils.h> doesn't exist on sandbox,
but also isn't needed here. It really is only needed in two files
because it only defines what should be generic math header functions.
So, here's my request. In a follow up patch, please do either of:
- Remove <asm/utils.h> from everything that doesn't call
  log_2_n_round_{up,down}.
- Remove arch/arm/include/asm/utils.h and replace the calls of
  log_2_n_round_(up,down} with what must be the common linux kernel
  equivalent that's been added in the last 15 years.

Thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20251105/88cb32ce/attachment.sig>