[PATCH RESEND 1/9] test: fdt_test_apply requires CONFIG_OF_LIBFDT_OVERLAY

[Heinrich Schuchardt]

On 11/11/25 09:29, Ilias Apalodimas wrote:
> Hi Heinrich
> 
> On Sun, 9 Nov 2025 at 12:10, Heinrich Schuchardt
> <heinrich.schuchardt at canonical.com> wrote:
>>
>> The `fdt apply` sub-command is only available if CONFIG_OF_LIBFDT_OVERLAY
>> is enabled.
>>
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
>> ---
>>   test/cmd/fdt.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/test/cmd/fdt.c b/test/cmd/fdt.c
>> index 96a8488e172..a36f2dcdda8 100644
>> --- a/test/cmd/fdt.c
>> +++ b/test/cmd/fdt.c
>> @@ -1319,6 +1319,9 @@ static int fdt_test_apply(struct unit_test_state *uts)
>>          char fdt[8192], fdto[8192];
>>          ulong addr, addro;
>>
>> +       if (!IS_ENABLED(CONFIG_OF_LIBFDT_OVERLAY))
>> +               return -EAGAIN;
> 
> The asserts return CMD_RET_FAILURE on failures. Should't we use the same here?

There is nothing wrong in CONFIG_OF_LIBFDT_OVERLAY=n. This is not a failure.

-EAGAIN signals a skipped test.
Look for EAGAIN in test/test-main.c.

We should describe this in doc/develop/tests_writing.rst.

Best regards

Heinrich

> 
>> +
>>          /* Create base DT with __symbols__ node */
>>          ut_assertok(fdt_create(fdt, sizeof(fdt)));
>>          ut_assertok(fdt_finish_reservemap(fdt));
>> --
>> 2.51.0
>>
> 
> Regards
> /Ilias