[PATCH] test/py: Use aligned address for overlays in 'extension' test
Marek Vasut
marek.vasut at mailbox.org
Wed Nov 12 16:24:34 CET 2025
On 11/12/25 2:35 PM, Tom Rini wrote:
> On Wed, Nov 12, 2025 at 03:02:21AM +0100, Marek Vasut wrote:
>> The 'extension' test would set 'extension_overlay_addr' variable to
>> decimal 4096 due to conversion in python. The 'extension_overlay_addr'
>> is however sampled using env_get_hex("extension_overlay_addr", 0);
>> which converts the 4096 to 0x4096 and uses that as DT overlay address,
>> which is unaligned. Fix this by setting extension_overlay_addr to 0x1000
>> as intended, which is aligned.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
>> ---
>> Cc: Heinrich Schuchardt <xypron.glpk at gmx.de>
>> Cc: Mattijs Korpershoek <mkorpershoek at kernel.org>
>> Cc: Simon Glass <sjg at chromium.org>
>> Cc: Tom Rini <trini at konsulko.com>
>> Cc: u-boot at lists.denx.de
>> ---
>> test/py/tests/test_extension.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/test/py/tests/test_extension.py b/test/py/tests/test_extension.py
>> index 61223496054..ddc62e7d5ca 100644
>> --- a/test/py/tests/test_extension.py
>> +++ b/test/py/tests/test_extension.py
>> @@ -38,7 +38,7 @@ def test_extension(ubman):
>> assert('overlay1.dtbo' in output)
>>
>> ubman.run_command_list([
>> - 'setenv extension_overlay_addr %s' % (overlay_addr),
>> + 'setenv extension_overlay_addr 0x%x' % (overlay_addr),
>> 'setenv extension_overlay_cmd \'host load hostfs - ${extension_overlay_addr} %s${extension_overlay_name}\'' % (os.path.join(ubman.config.build_dir, OVERLAY_DIR))])
>>
>> output = ubman.run_command('extension apply 0')
>
> As we often get patches to remove the "0x" portion, can you just correct
> the format character? Thanks!
Do you mean s at 0x%x@%x@ in this patch ?
More information about the U-Boot
mailing list