[PATCH 00/11] led: remove u-boot, boot-led and u-boot, error-led + add cmd doc

[Patrice CHOTARD]

On 11/12/25 18:48, Quentin Schulz wrote:
> u-boot,boot-led and u-boot,error-led aren't actually handled by some
> generic code but rather by board or architecture specific code. They
> also aren't properties that are part of the official dt-binding so they
> cannot be upstreamed. For u-boot,boot-led, there's actually a proper
> replacement which is /options/u-boot/boot-led[1] (+ CONFIG_LED_BOOT=y).
> 
> For Rockchip boards, either nothing (for RK3066, PX30 and RK3399) was
> using that property or (for RK3188) the code handling it was guarded by
> symbols that were not enabled in the defconfig. For those, the property
> and guarded code are removed.
> 
> For the Sam9x60 Curiosity, it seems that even though the LED is
> controlled whenever CONFIG_LED is enabled, it isn't enabled by default
> in the defconfig (but the code was added without modifying the
> defconfig, explicitly leaving a choice to the user). I decided to keep
> that feature by simply migrating it to the new API, though I cannot test
> it as I do not own the device.
> 
> The STM32 boards will be migrated in the near future once their upstream
> (kernel) Device Trees gain the new way to specify this (via
> /options/u-boot/boot-led). I'll let Patrice handle this, see
> https://lore.kernel.org/u-boot/94ed1988-13e8-4fe3-bdff-ba2c9973c556@foss.st.com/
> and
> https://lore.kernel.org/u-boot/2a3aa43a-ce19-41e1-ab56-556629ce5cf9@foss.st.com/
> 

Hi Quentin

As mentioned, the 2 above U-Boot series about STM32 led update will be soon superseeded 
by a new series.

On kernel side i submitted a DTS update for STMicroelectronics boards: 

https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=1022526
https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=1022570

We will heritate of this update when U-Boot DT will be synchronized with kernel DT
(probably linux v6.19 i guess).

> After this, only one user of u-boot,boot-led will be left, based on
> STM32: board/dhelectronics/dh_stm32mp1/board.c. @Patrice, maybe that's
> something you want to have a look at as well, this seems to be some
> evaluation kit?

I will let Marek to take care of dhelectronics board.

Thanks

> 
> The only users of u-boot,error-led are STM32 boards, so I'll leave this
> to Patrice as well, I do not know what's the way to go for that one.
> 
> In any case, I would like to not encourage people to use out-of-spec DT
> properties when there is another option (u-boot,boot-led), so I remove
> the properties from the dt-binding document from U-Boot.
> 
> The help text for the blink subcommand of the led command was misleading
> so this is now fixed.
> 
> This also moves the content of doc/README.LED into the doc/api/led.rst,
> while clearly stating one shouldn't be using this anymore.
> 
> This also gets rid of dt-binding that we already have in dts/upstream.
> 
> Finally, this adds documentation for the led shell command.
> 
> [1] https://github.com/devicetree-org/dt-schema/blob/v2025.08/dtschema/schemas/options/u-boot.yaml#L113-L116
> 
> Reported-by: Yegor Yefremov <yegorslists at googlemail.com>
> Signed-off-by: Quentin Schulz <quentin.schulz at cherry.de>
> ---
> Quentin Schulz (11):
>       cmd: led: fix help text for blink subcommand
>       doc: move legacy API documented in README.LED to doc/api/led.rst
>       doc: cmd: document the led shell command
>       doc: dt-bindings: remove duplicates with dts/upstream
>       arm: dts: rockchip: rk3188-radxarock: remove unused u-boot,boot-led
>       rockchip: rk3188: remove setup_led from xPL
>       arm: dts: rockchip: rk3399-puma: remove u-boot,boot-led
>       arm: dts: rockchip: px30-ringneck: remove u-boot,boot-led
>       arm: dts: rockchip: rk3066a-mk808: remove unused u-boot,boot-led
>       sam9x60-curiosity: migrate Boot LED setup to use /options/u-boot/boot-led
>       doc: remove u-boot,boot-led and u-boot,error-led from "binding"
> 
>  arch/arm/dts/at91-sam9x60_curiosity-u-boot.dtsi   |   9 +-
>  arch/arm/dts/px30-ringneck-haikou-u-boot.dtsi     |   1 -
>  arch/arm/dts/rk3066a-mk808-u-boot.dtsi            |   6 -
>  arch/arm/dts/rk3188-radxarock-u-boot.dtsi         |   5 -
>  arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi       |   1 -
>  arch/arm/mach-rockchip/Kconfig                    |   1 -
>  arch/arm/mach-rockchip/rk3188/rk3188.c            |  36 ------
>  board/atmel/sam9x60_curiosity/sam9x60_curiosity.c |  16 +--
>  cmd/led.c                                         |  11 +-
>  doc/README.LED                                    |  77 ------------
>  doc/api/led.rst                                   |  89 +++++++++++++-
>  doc/device-tree-bindings/config.txt               |   5 -
>  doc/device-tree-bindings/leds/leds-bcm6328.txt    | 106 ----------------
>  doc/device-tree-bindings/leds/leds-bcm6358.txt    | 141 ----------------------
>  doc/device-tree-bindings/leds/leds-gpio.txt       |  52 --------
>  doc/device-tree-bindings/leds/leds-lp5562.txt     |  63 ----------
>  doc/usage/cmd/led.rst                             |  95 +++++++++++++++
>  17 files changed, 194 insertions(+), 520 deletions(-)
> ---
> base-commit: caa740df9cae5ddc74b18b88a4fea43e27b2fdf6
> change-id: 20251112-led-old-dt-dc24605ddc88
> 
> Best regards,