[PATCH 0/6] fat: Some code improvements

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Thu Nov 13 14:45:37 CET 2025


On 11/13/25 14:30, Tom Rini wrote:
> On Thu, Nov 13, 2025 at 07:46:50AM +0100, Heinrich Schuchardt wrote:
> 
>> From: Simon Glass <simon.glass at canonical.com>
>>
>> This is an attempt to improve the structure of the FAT code, since it
>> doesn't fully follow the U-Boot conventions:
>>
>> - fat_write.c includes fat.c which is odd
>> - use of __u32 and its ilk
>> - use of typedef
>> - old-style struct comments
>>
>> This series resolves these problems, making it easier to take on other
>> improvements in future.
> 
> We don't have an AI policy for the project at this time. My current
> inclination is we should follow:
> https://docs.postmarketos.org/policies-and-processes/development/contributing-and-ai.html

I cannot see that Simon's work would violate a policy like the one above.

> So I'm inclined to defer this until there's some "other improvements in
> the future", that are both useful

Could you, please, describe what you dislike about the content of the 
changes.

 > and hopefully only human developed.

With your reaction you will probably push contributors to simply not 
mention which tools they have used.

Best regards

Heinrich



More information about the U-Boot mailing list