[PATCH 3/9] test: cmd/bdinfo: make no flash assumption

Simon Glass sjg at chromium.org
Fri Nov 14 13:44:04 CET 2025


Hi Heinrich,

On Sun, 9 Nov 2025 at 03:10, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
> The location and size of flash is device-dependent. Do not make any
> assumption about the location and size.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> ---
>  test/cmd/bdinfo.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/test/cmd/bdinfo.c b/test/cmd/bdinfo.c
> index 09f44ee41ed..214b237152b 100644
> --- a/test/cmd/bdinfo.c
> +++ b/test/cmd/bdinfo.c
> @@ -161,9 +161,9 @@ static int bdinfo_test_all(struct unit_test_state *uts)
>         ut_assertok(bdinfo_check_mem(uts));
>
>         /* CONFIG_SYS_HAS_SRAM testing not supported */
> -       ut_assertok(test_num_l(uts, "flashstart", 0));
> -       ut_assertok(test_num_l(uts, "flashsize", 0));
> -       ut_assertok(test_num_l(uts, "flashoffset", 0));
> +       ut_check_console_linen(uts, "flashstart");
> +       ut_check_console_linen(uts, "flashsize");
> +       ut_check_console_linen(uts, "flashoffset");
>         ut_assert_nextline("baudrate    = %lu bps",
>                            env_get_ulong("baudrate", 10, 1234));
>         ut_assertok(test_num_l(uts, "relocaddr", gd->relocaddr));
> --
> 2.51.0
>

Shouldn't we check the actual value, then?

Reviewed-by: Simon Glass <sjg at chromium.org>

Regards,
Simon


More information about the U-Boot mailing list