[PATCH 6/9] test: cmd/fdt: do not use fixed buffer addresses

[Tom Rini]

On Fri, Nov 14, 2025 at 07:24:53AM -0700, Simon Glass wrote:
> Hi Tom,
> 
> On Fri, 14 Nov 2025 at 07:19, Tom Rini <trini at konsulko.com> wrote:
> >
> > On Fri, Nov 14, 2025 at 05:31:40AM -0700, Simon Glass wrote:
> > > Hi Heinrich,
> > >
> > > On Sun, 9 Nov 2025 at 03:10, Heinrich Schuchardt
> > > <heinrich.schuchardt at canonical.com> wrote:
> > > >
> > > > The location of memory depends on the board. Do not assume memory at fixed
> > > > memory locations. Use memalign() instead to allocate a buffer.
> > > >
> > > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> > [snip]
> > > >         /* bytes */
> > > >         print_hex_dump_bytes("", DUMP_PREFIX_ADDRESS, buf, 0x12);
> > > >         ut_assert_nextline("%0*lx: 00 11 22 33 44 55 66 77 88 99 aa bb cc dd ee ff  ..\"3DUfw........",
> > > > -                          IS_ENABLED(CONFIG_PHYS_64BIT) ? 16 : 8,
> > > > -                          (uintptr_t)buf);
> > > > +                          IS_ENABLED(CONFIG_PHYS_64BIT) ? 16 : 8, addr);
> > [snip]
> > > This is adding memory allocations to a test for hex dumping.
> > >
> > > It would be better and simpler to use a fixed address and make this a
> > > sandbox-only test. I struggle to see the value of running these sorts
> > > of tests under QEMU?
> >
> > Removing context to highlight value of running tests on multiple
> > platforms.
> 
> $ ./tools/qconfig.py -f ~PHYS_64BIT -l |grep sandbox
> sandbox
> sandbox_flattree
> sandbox_nocmdline
> sandbox_noinst
> sandbox_spl
> sandbox_vpl
> $ ./tools/qconfig.py -f PHYS_64BIT -l |grep sandbox
> sandbox64
> sandbox64_lwip

Good, and as soon as you restrict to "sandbox" we stop running
"sandbox64", it's why sandbox64 runs so much quicker in CI.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20251114/b16909ac/attachment.sig>