[PATCH v2] board: ti: am335x: Do not call disabled PMIC functions

Maarten Brock Maarten.Brock at sttls.nl
Tue Nov 18 12:03:56 CET 2025


Hello Markus,

> > diff --git a/board/ti/am335x/board.c b/board/ti/am335x/board.c
> > index 4ada8b534c1..712818ec235 100644
> > --- a/board/ti/am335x/board.c
> > +++ b/board/ti/am335x/board.c
> > @@ -426,6 +429,9 @@ void scale_vcores_generic(int freq)
> >  {
> >  	int sil_rev, mpu_vdd;
> >
> > +	if (!IS_ENABLED(CONFIG_DM_PMIC_TPS65910))
> > +		return;
> > +
> 
> If I understand this function correctly, the functions used for tps65910
> in scale_vcores_generic are not depending on CONFIG_DM_PMIC_TPS65910,
> but on CONFIG_SPL_POWER_TPS65910:
> 
>   obj-$(CONFIG_DM_PMIC_TPS65910) += pmic_tps65910_dm.o
>   obj-$(CONFIG_SPL_POWER_TPS65910) += pmic_tps65910.o

You are right and I appologise for making this mistake.

> I am currently not able to test the TPS65217 parts of this patch.

I rechecked the TPS65217 part and still think it is correct.

> I will probably send a fix for am335x-evm tomorrow.
> 
> Best
> Markus

Kind Regards,
Maarten



More information about the U-Boot mailing list