[PATCH 1/5] led: remove code guarded by always false conditions
Quentin Schulz
foss+uboot at 0leil.net
Wed Nov 19 17:43:45 CET 2025
From: Quentin Schulz <quentin.schulz at cherry.de>
The last CONFIG_MVS in code was removed almost 12 years ago in commit
3b98b57fa796 ("include: delete unused header files").
STATUS_LED_PAR was last seen 8 years ago when removed in commit
5b8e76c35ec3 ("powerpc, 8xx: remove support for 8xx").
If CONFIG_LED_STATUS_BOARD_SPECIFIC is not defined, the build will fail
so we won't even reach this part of the code.
Let's simplify the if block to actually possible configurations.
Signed-off-by: Quentin Schulz <quentin.schulz at cherry.de>
---
include/status_led.h | 23 +----------------------
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/include/status_led.h b/include/status_led.h
index 1282022253e..56d519f6d53 100644
--- a/include/status_led.h
+++ b/include/status_led.h
@@ -46,23 +46,7 @@ static inline void status_led_boot_blink(void)
#endif
}
-/***** MVS v1 **********************************************************/
-#if (defined(CONFIG_MVS) && CONFIG_MVS < 2)
-# define STATUS_LED_PAR im_ioport.iop_pdpar
-# define STATUS_LED_DIR im_ioport.iop_pddir
-# undef STATUS_LED_ODR
-# define STATUS_LED_DAT im_ioport.iop_pddat
-
-# define STATUS_LED_ACTIVE 1 /* LED on for bit == 1 */
-
-/***** Someone else defines these *************************************/
-#elif defined(STATUS_LED_PAR)
- /*
- * ADVICE: Define in your board configuration file rather than
- * filling this file up with lots of custom board stuff.
- */
-
-#elif defined(CONFIG_LED_STATUS_BOARD_SPECIFIC)
+#if defined(CONFIG_LED_STATUS_BOARD_SPECIFIC)
/* led_id_t is unsigned long mask */
typedef unsigned long led_id_t;
@@ -73,11 +57,6 @@ void __led_blink(led_id_t mask, int freq);
#else
# error Status LED configuration missing
#endif
-/************************************************************************/
-
-#ifndef CONFIG_LED_STATUS_BOARD_SPECIFIC
-# include <asm/status_led.h>
-#endif
#else
--
2.51.1
More information about the U-Boot
mailing list