[PATCH] efi_loader: Assure fitImage from capsule is used from 8-byte aligned address

[Ilias Apalodimas]

On Thu, 20 Nov 2025 at 13:57, Marek Vasut <marek.vasut at mailbox.org> wrote:
>
> On 11/20/25 7:10 AM, Ilias Apalodimas wrote:
>
> Hello Ilias,
>
> >>>>> Initialize img to NULL and make the check a bit simpler to read (or
> >>>>> get rid of it overall)
> >>>> This part ^ I do not understand. The img variable is used by
> >>>> fit_update(img) , where should it be initialized to NULL ?
> >>>
> >>> The patch might be misleading since it doesn't show the entire
> >>> function. But from what I saw 'img' is only initialized when
> >>> 'if ((uintptr_t)image & 7)' is true. you can initialize img to NULL on
> >>> the declaration and just check for that.
> >>
> >> The 'img' is always initialized, see this:
> >>
> >> "
> >> +       if ((uintptr_t)image & 7) {
> >> +               img = memalign(8, image_size);
> >>                   ^^^ ----------------------- Here it is initialized
> >> +               if (!img)
> >> +                       return EFI_EXIT(EFI_BAD_BUFFER_SIZE);
> >> +               memcpy(img, image, image_size);
> >> +       } else {
> >> +               img = (void *)image;
> >>                   ^^^ ----------------------- Here it is initialized too
> >> +       }
> >> "
> >
> > Which I somehow missed reading the patch...
> Therefore I assume, we can wrap this part of your feedback up ?
>
> Thank you for your help !

yw, yes we can wrap it the patch is fine.
Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>