[PATCH] tegra: Stop disabling device tree relocation
Tom Rini
trini at konsulko.com
Thu Nov 20 17:16:48 CET 2025
On Thu, Nov 20, 2025 at 06:13:43PM +0200, Svyatoslav Ryhel wrote:
> ср, 19 лист. 2025 р. о 16:55 Tom Rini <trini at konsulko.com> пише:
> >
> > Remove setting of fdt_high to ~0, which disables device tree relocation,
> > from the default environment. Doing so prevents U-Boot from correcting
> > problems such as having an unaligned device tree and leads to various
> > failure modes in the OS.
> >
> > Signed-off-by: Tom Rini <trini at konsulko.com>
> > ---
> > If there is some window of memory that must be used for where the device
> > tree is relocated to, bootm_low + bootm_size (or often just bootm_size)
> > or bootm_mapsize are the correct way do this. Please see
> > doc/usage/environment.rst for more details.
> >
> > Cc: Svyatoslav Ryhel <clamor95 at gmail.com>
> > Cc: Thierry Reding <treding at nvidia.com>
> > ---
> > include/configs/tegra-common-post.h | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/include/configs/tegra-common-post.h b/include/configs/tegra-common-post.h
> > index 2f08dfed020f..a9c0cea4e149 100644
> > --- a/include/configs/tegra-common-post.h
> > +++ b/include/configs/tegra-common-post.h
> > @@ -50,17 +50,14 @@
> > #endif
> >
> > #ifdef CONFIG_ARM64
> > -#define FDT_HIGH "ffffffffffffffff"
> > #define INITRD_HIGH "ffffffffffffffff"
> > #else
> > -#define FDT_HIGH "ffffffff"
> > #define INITRD_HIGH "ffffffff"
> > #endif
> >
> > #define CFG_EXTRA_ENV_SETTINGS \
> > TEGRA_DEVICE_SETTINGS \
> > MEM_LAYOUT_ENV_SETTINGS \
> > - "fdt_high=" FDT_HIGH "\0" \
> > "initrd_high=" INITRD_HIGH "\0" \
> > "boot_targets=" BOOT_TARGETS "\0" \
> > BOARD_EXTRA_ENV_SETTINGS
> > --
> > 2.43.0
> >
>
> Thank you! Overall change seems to be valid and should not break
> anything. Unfortunately, ATM I have some major technical difficulties
> with testing and PC access overall. I try to find an opportunity to
> test and verify it ASAP. Would you mind if I include note after ---
> into commit message? (no additional actions needed from you).
Yes, please feel free to amend the commit message when you take this to
your tree. It's not urgently needed (this is for v2026.04) and will be
preceded in the tree by the patch that warns users that fdt_high is set
like this and so may cause problems.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20251120/733af3f1/attachment.sig>
More information about the U-Boot
mailing list