[PATCH v2] binman: blob_dtb: improve error message when SPL is not found
Jérémie Dautheribes
jeremie.dautheribes at bootlin.com
Fri Nov 28 12:03:04 CET 2025
When using binman with the '-a spl-dtb=y' flag, if the SPL blob is not
found, binman throws a cryptic error message:
binman: 'NoneType' object has no attribute 'startswith'
Let's improve the error message to explicitly state which SPL blob is
missing.
This is particularly useful when binman is used as a standalone tool
outside the U-Boot source tree.
Signed-off-by: Jérémie Dautheribes <jeremie.dautheribes at bootlin.com>
---
Changes in v2:
- added comment annotation for python coverage as requested by Tom Rini
tools/binman/etype/blob_dtb.py | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tools/binman/etype/blob_dtb.py b/tools/binman/etype/blob_dtb.py
index b234323d7cf..5d4817257bc 100644
--- a/tools/binman/etype/blob_dtb.py
+++ b/tools/binman/etype/blob_dtb.py
@@ -8,6 +8,8 @@
from binman.entry import Entry
from binman.etype.blob import Entry_blob
from dtoc import fdt_util
+import errno
+import os
import struct
# This is imported if needed
@@ -39,9 +41,16 @@ class Entry_blob_dtb(Entry_blob):
(self._node.name, self.prepend))
def ObtainContents(self, fake_size=0):
- """Get the device-tree from the list held by the 'state' module"""
+ """Get the device-tree from the list held by the 'state' module
+
+ Raises:
+ FileNotFoundError: If the device-tree blob is not found.
+ """
self._filename = self.GetDefaultFilename()
self._pathname, _ = self.FdtContents(self.GetFdtEtype())
+ if self._pathname is None:
+ raise FileNotFoundError(errno.ENOENT,
+ os.strerror(errno.ENOENT), self._filename)
return super().ReadBlobContents()
def ProcessContents(self):
--
2.43.0
More information about the U-Boot
mailing list