[PATCH v1 2/4] ehci-mx6: Update USB host driver for iMX8ULP
Marek Vasut
marek.vasut at mailbox.org
Sun Nov 30 02:06:14 CET 2025
On 11/28/25 2:16 PM, alice.guo at oss.nxp.com wrote:
[...]
> -#if defined(CONFIG_MX7ULP) && !defined(CONFIG_PHY)
> +#if (defined(CONFIG_MX7ULP) || defined(CONFIG_IMX8ULP)) && !defined(CONFIG_PHY)
> static void usb_power_config_mx7ulp(struct usbphy_regs __iomem *usbphy)
> {
> - if (!is_mx7ulp())
> + if (!(is_mx7ulp() || is_imx8ulp()))
> return;
>
> writel(ANADIG_USB2_CHRG_DETECT_EN_B |
> ANADIG_USB2_CHRG_DETECT_CHK_CHRG_B,
> &usbphy->usb1_chrg_detect);
>
> +#if IS_ENABLED(CONFIG_IMX8ULP)
if (IS_ENABLED(...)) , but really , can we avoid the ifdeffery altogether ?
> + enable_usb_pll((ulong)usbphy);
> +#else
> scg_enable_usb_pll(true);
> +#endif
[...]
> @@ -620,13 +632,15 @@ static int mx6_parse_dt_addrs(struct udevice *dev)
> if (misc_off < 0)
> return -EINVAL;
>
> - addr = (void __iomem *)fdtdec_get_addr(blob, phy_off, "reg");
> + addr = (void __iomem *)fdtdec_get_addr_size_auto_noparent(blob, phy_off,
> + "reg", 0, NULL, false);
Separate patch please . Also, why this change ?
More information about the U-Boot
mailing list