[PATCH] video: nexell: unsigned parameter cannot be negative

[Stefan Bosch]

Hi Andrew,

On 01.10.25 12:05, Andrew Goodbody wrote:
> The parameter 'alpha' is declared as an unsigned type so cannot be
> negative. The code to test it as being less than zero will always fail
> and so is redundant and should be removed.
> 
> This issue was found by Smatch.
> 
> Signed-off-by: Andrew Goodbody <andrew.goodbody at linaro.org>
> ---
> There is no call to this function currently in the tree so maybe it
> should just be removed entirely?
> ---
>   drivers/video/nexell/soc/s5pxx18_soc_mlc.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/video/nexell/soc/s5pxx18_soc_mlc.c b/drivers/video/nexell/soc/s5pxx18_soc_mlc.c
> index c8cf833f308836aa9205f4ed2148e41075b83c29..2c8348bf633929272d084b407dd4bc247eff21b4 100644
> --- a/drivers/video/nexell/soc/s5pxx18_soc_mlc.c
> +++ b/drivers/video/nexell/soc/s5pxx18_soc_mlc.c
> @@ -1641,8 +1641,6 @@ void nx_mlc_set_layer_alpha256(u32 module_index, u32 layer, u32 alpha)
>   	u32 register_data;
>   	register struct nx_mlc_register_set *pregister;
>   
> -	if (alpha < 0)
> -		alpha = 0;
>   	if (alpha > 255)
>   		alpha = 255;
>   
> 
> ---
> base-commit: b2d5e46c67002e46ac339ef549ea18cf5adfcd87
> change-id: 20251001-video_nexell-f93362a0bf72
> 
> Best regards,

Reviewed-by: Stefan Bosch <stefan_b at posteo.net>

In my opinion, you can remove the entire function if you like.

Thanks a lot,
Stefan